harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HARMONY-1243) [luni] bootclasspath property issues
Date Thu, 24 Aug 2006 20:16:08 GMT
     [ http://issues.apache.org/jira/browse/HARMONY-1243?page=all ]

Alexey Varlamov updated HARMONY-1243:

    Attachment: boot2.diff

Here is more robust implementation of property file parsing and bootclasspath composing.
The parser follows common property file syntax: any of '\r', '\n' are line separators and
'#' or '!' mark comment line.
I still think that some of these functions better be added to portlib, namely:

char * str_concat (HyPortLibrary * portLibrary, ...);
int props_read_from_file(HyPortLibrary * portLibrary, const char *filename, 
                          key_value_pair** properties, U_32 *number);
void props_free(HyPortLibrary * portLibrary, key_value_pair * properties);

> [luni] bootclasspath property issues
> ------------------------------------
>                 Key: HARMONY-1243
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1243
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexey Varlamov
>         Attachments: boot2.diff
> There are several issues with reading file "bootclasspath.properties" and setting "org.apache.harmony.boot.class.path"
> 1) readClassPathFromPropertiesFile() in modules\luni\src\main\native\luni\shared\luniglob.c
loops infinitely if the file does not end with platform-dependent line separator;
> 2) The same function does not respect numbering of elements, simply concatenates in the
same order as they appear in the file;
> 3) The same function uncoditionally rewrites the property, enforcing somewhat sinuous
contract for a VM: the latter must load and init hyluni.dll(so) before updating this property.
> Besides, the name of this property better be defined in some exported header of the classlib...

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message