harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulex Yang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1222) [classlib][luni]org.apache.harmony.luni.platform.Environment fails to recognize environment name case-incensitively on win32 platform.
Date Mon, 21 Aug 2006 04:07:15 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1222?page=comments#action_12429335 ] 
            
Paulex Yang commented on HARMONY-1222:
--------------------------------------

Leo, I have some thoughts on this patch:
1. The patch used GetByteArrayRegion, but actually it always get the whole array, if the GetByteArrayElements
or GetPrimitiveArrayCritical is used instead, there is chance not to copy the contents, so
that the performance will be a little better.
2. Some variable(jbyteArray bytes) in the Windows natives is not used
3. Seems lpszVar in Windows natives needs to be freed explicitly?
4. I suggest to use hymem_allocate/free_memory to replace all the malloc/free, so that all
native codes can have a unified memory management module.

Any problems, please let me know, thank you.

> [classlib][luni]org.apache.harmony.luni.platform.Environment fails to recognize environment
name case-incensitively on win32 platform.
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1222
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1222
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Leo Li
>         Assigned To: Paulex Yang
>         Attachments: patch.diff
>
>
> org.apache.harmony.luni.platform.Environment fails to recognize environment name case-incensitively
on win32 platform, but RI does. RI accepts "PATH" the same as "path" on win32 but not on linux.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message