Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Message-ID: <9749256.1152150750156.JavaMail.jira@brutus>
Date: Thu, 6 Jul 2006 01:52:30 +0000 (GMT+00:00)
From: "Andrew Zhang (JIRA)" <jira@apache.org>
To: harmony-commits@incubator.apache.org
Subject: [jira] Commented: (HARMONY-755) [classlib][nio] Refine tests in
 o.a.h.tests.java.nio.channels.SocketChannelTest
In-Reply-To: <11421680.1152070589767.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/HARMONY-755?page=comments#action_12419385 ] 

Andrew Zhang commented on HARMONY-755:
--------------------------------------

Hello George,

The problem was found. 

It's caused by different platform behaviours of SocketChannel.connect() and finishConnect(). 

There are 8 FIXMEs  in SocketChannel about this issue. The FIXME looks like:

"// FIXME: assertEquals(e.getMessage(), "Connection refused");"

I have noticed it before. But for my careless, I forgot this issue during refining these tests.

For these FIXMEs, I have to wait for test structure layout, or some other control methods for platform dependent test.

So I'll leave these FIXMEs as original, and upload a new patch to remove the unrelated test "testConnect_Lock". 

Really sorry for my mistakes.  

Best regards,
Andrew

> [classlib][nio] Refine tests in o.a.h.tests.java.nio.channels.SocketChannelTest
> -------------------------------------------------------------------------------
>
>          Key: HARMONY-755
>          URL: http://issues.apache.org/jira/browse/HARMONY-755
>      Project: Harmony
>         Type: Test

>   Components: Classlib
>     Reporter: Andrew Zhang
>     Assignee: George Harley
>  Attachments: nio.diff
>
> Refine tests in o.a.h.tests.java.nio.channels.SocketChannelTest. 
> There are some system.err/out and bad tests in SocketChannelTest. I'll fix some of them in this patch.
> 1. testConnect_Lock. This method has nothing to do with SocketChannel, and it always output some logs to stdout. I'll remove this method.  In fact, it tests something about Socket, not SocketChannel. 
> 2. Fix system.out/err in testCFII_Data_FinishConnect_ServerStartLater, testCFII_Data_FinishConnect_AddrSetServerStartLater.
> I'll upload a patch soon.
> Thanks!
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira