Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Message-ID: <33208033.1152586050183.JavaMail.jira@brutus>
Date: Tue, 11 Jul 2006 02:47:30 +0000 (GMT+00:00)
From: "Vladimir Ivanov (JIRA)" <jira@apache.org>
To: harmony-commits@incubator.apache.org
Subject: [jira] Commented: (HARMONY-791) [classlib][lang] unexpected
 NegativeArraySizeException for java.lang.String(int[], 2,
 Integer.MAX_VALUE)
In-Reply-To: <28231496.1152244589769.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/HARMONY-791?page=comments#action_12420197 ] 

Vladimir Ivanov commented on HARMONY-791:
-----------------------------------------

The correct patch is:
Index: C:/harmony/trunk_0427/modules/luni/src/main/java/java/lang/String.java
===================================================================
--- C:/harmony/trunk_0427/modules/luni/src/main/java/java/lang/String.java	(revision 419772)
+++ C:/harmony/trunk_0427/modules/luni/src/main/java/java/lang/String.java	(working copy)
@@ -498,7 +498,7 @@
         super();
         if (codePoints == null)
             throw new NullPointerException();
-        if (offset < 0 || count < 0 || (offset + count) > codePoints.length)
+        if (offset < 0 || count < 0 || (long)offset + (long)count > codePoints.length)
             throw new IndexOutOfBoundsException();
         this.offset = 0;
         this.value = new char[count * 2];


> [classlib][lang] unexpected NegativeArraySizeException for java.lang.String(int[], 2, Integer.MAX_VALUE)
> --------------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-791
>          URL: http://issues.apache.org/jira/browse/HARMONY-791
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Vladimir Ivanov
>  Attachments: String.java.patch, String.patch, StringTest.patch
>
> The harmony method java.lang.String(int[], 2, Integer.MAX_VALUE) throws NegativeArraySizeException while spec requires IndexOutOfBoundsException. 
> ================== test.java =======================
> public class test  {
>     public static void main (String[] args) { 
>           new String(new int[] {}, 2, Integer.MAX_VALUE);                                                     
>     } 
> }
> ================================================
> Output:
> C:\tmp\tmp17>C:\jrockit-jdk1.5.0-windows-ia32\bin\java.exe -showversion test
> java version "1.5.0"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0-b64)
> BEA WebLogic JRockit(R) (build dra-38972-20041208-2001-win-ia32, R25.0.0-75, GC: System optimized over throughput (initial strategy singleparpar))
> java.lang.StringIndexOutOfBoundsException: String index out of range: -2147483647
>         at java.lang.String.<init>([III)V(Unknown Source)
>         at test.main(test.java:3)
> C:\tmp\tmp17>C:\harmony\trunk_0427\deploy\jdk\jre\bin\java.exe -showversion test
> java version 1.5 (subset)
> (c) Copyright 1991, 2006 The Apache Software Foundation or its licensors, as applicable.
> Exception in thread "main" java.lang.NegativeArraySizeException
>         at java.lang.String.<init>(String.java:504)
>         at test.main(test.java:3)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira