Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Message-ID: <26911002.1152005671610.JavaMail.jira@brutus>
Date: Tue, 4 Jul 2006 09:34:31 +0000 (GMT+00:00)
From: "George Harley (JIRA)" <jira@apache.org>
To: harmony-commits@incubator.apache.org
Subject: [jira] Closed: (HARMONY-686) [classlib][nio] Refactor
 SocketAdapter.checkClosedAndCreate(boolean) in
 o.a.h.nio.internal.SocketChannelImpl
In-Reply-To: <28396653.1151482349866.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

     [ http://issues.apache.org/jira/browse/HARMONY-686?page=all ]
     
George Harley closed HARMONY-686:
---------------------------------


Verified by Andrew.

> [classlib][nio] Refactor SocketAdapter.checkClosedAndCreate(boolean) in o.a.h.nio.internal.SocketChannelImpl
> ------------------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-686
>          URL: http://issues.apache.org/jira/browse/HARMONY-686
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Andrew Zhang
>     Assignee: George Harley
>     Priority: Minor
>  Attachments: nio.diff
>
> There are several problems in SocketAdapter.checkClosedAndCreate(boolean) method:
> 1. Unused parameter. The boolean parameter is unnecessary.
> 2. Improper method name. This method only checks whether the channel is open, and has nothing to do with "create".
> 3. One FIXME. 
> I'll upload a patch soon. Thanks!
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira