Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r420819 - in
 /incubator/harmony/enhanced/classlib/trunk/modules/security/src:
 main/java/common/javax/security/cert/X509Certificate.java
 test/api/java/org/apache/harmony/security/tests/javax/security/cert/X509CertificateTest.java
Date: Tue, 11 Jul 2006 12:29:55 -0000
To: harmony-commits@incubator.apache.org
From: tellison@apache.org
Message-Id: <20060711122956.15AD91A981A@eris.apache.org>

Author: tellison
Date: Tue Jul 11 05:29:54 2006
New Revision: 420819

URL: http://svn.apache.org/viewvc?rev=420819&view=rev
Log:
Apply patch HARMONY-756 ([classlib][security]javax.security.cert.X509Certificate.getInstance((null) throws unspecified NPE)

Modified:
    incubator/harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/javax/security/cert/X509Certificate.java
    incubator/harmony/enhanced/classlib/trunk/modules/security/src/test/api/java/org/apache/harmony/security/tests/javax/security/cert/X509CertificateTest.java

Modified: incubator/harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/javax/security/cert/X509Certificate.java
URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/javax/security/cert/X509Certificate.java?rev=420819&r1=420818&r2=420819&view=diff
==============================================================================
--- incubator/harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/javax/security/cert/X509Certificate.java (original)
+++ incubator/harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/javax/security/cert/X509Certificate.java Tue Jul 11 05:29:54 2006
@@ -1,264 +1,270 @@
-/*
- *  Copyright 2005 The Apache Software Foundation or its licensors, as applicable.
- *
- *  Licensed under the Apache License, Version 2.0 (the "License");
- *  you may not use this file except in compliance with the License.
- *  You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- *  Unless required by applicable law or agreed to in writing, software
- *  distributed under the License is distributed on an "AS IS" BASIS,
- *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- *  See the License for the specific language governing permissions and
- *  limitations under the License.
- */
-
-/**
-* @author Alexander Y. Kleymenov
-* @version $Revision$
-*/
-
-package javax.security.cert;
-
-import java.io.ByteArrayInputStream;
-import java.io.InputStream;
-import java.lang.reflect.Constructor;
-import java.math.BigInteger;
-import java.security.AccessController;
-import java.security.InvalidKeyException;
-import java.security.NoSuchAlgorithmException;
-import java.security.NoSuchProviderException;
-import java.security.Principal;
-import java.security.PublicKey;
-import java.security.Security;
-import java.security.SignatureException;
-import java.security.cert.CertificateFactory;
-import java.util.Date;
-import javax.security.cert.Certificate;
-import javax.security.cert.CertificateEncodingException;
-import javax.security.cert.CertificateException;
-import javax.security.cert.CertificateExpiredException;
-import javax.security.cert.CertificateNotYetValidException;
-
-/**
- * @com.intel.drl.spec_ref
- */
-public abstract class X509Certificate extends Certificate {
-
-    private static Constructor constructor;
-    
-    static {
-        try {
-            String classname = (String) AccessController.doPrivileged(
-                new java.security.PrivilegedAction() {
-                    public Object run() {
-                        return Security.getProperty("cert.provider.x509v1");
-                    }
-                }
-            );
-            Class cl = Class.forName(classname);
-            constructor =
-                cl.getConstructor(new Class[] {InputStream.class});
-        } catch (Throwable e) {
-        }
-    }
-    
-    /**
-     * @com.intel.drl.spec_ref
-     */
-    public X509Certificate() {
-        super();
-    }
-
-    /**
-     * @com.intel.drl.spec_ref
-     */
-    public static final X509Certificate getInstance(InputStream inStream)
-                                             throws CertificateException {
-        if (constructor != null) {
-            try {
-                return (X509Certificate) 
-                    constructor.newInstance(new Object[] {inStream});
-            } catch (Throwable e) {
-                throw new CertificateException(e.getMessage());
-            }
-        }
-
-        final java.security.cert.X509Certificate cert;
-        try {
-            CertificateFactory cf = CertificateFactory.getInstance("X.509");
-            cert = (java.security.cert.X509Certificate)
-                                            cf.generateCertificate(inStream);
-        } catch (java.security.cert.CertificateException e) {
-            throw new CertificateException(e.getMessage());
-        }
-
-        return new X509Certificate() {
-
-            public byte[] getEncoded() throws CertificateEncodingException {
-                try {
-                    return cert.getEncoded();
-                } catch (java.security.cert.CertificateEncodingException e) {
-                    throw new CertificateEncodingException(e.getMessage());
-                }
-            }
-
-            public void verify(PublicKey key) throws CertificateException,
-                                NoSuchAlgorithmException, InvalidKeyException,
-                                NoSuchProviderException, SignatureException {
-                try {
-                    cert.verify(key);
-                } catch (java.security.cert.CertificateException e) {
-                    throw new CertificateException(e.getMessage());
-                }
-            }
-
-            public void verify(PublicKey key, String sigProvider)
-                            throws CertificateException,
-                                NoSuchAlgorithmException, InvalidKeyException,
-                                NoSuchProviderException, SignatureException {
-                try {
-                    cert.verify(key, sigProvider);
-                } catch (java.security.cert.CertificateException e) {
-                    throw new CertificateException(e.getMessage());
-                }
-            }
-
-            public String toString() {
-                return cert.toString();
-            }
-
-            public PublicKey getPublicKey() {
-                return cert.getPublicKey();
-            }
-
-            public void checkValidity() throws CertificateExpiredException,
-                                   CertificateNotYetValidException {
-                try {
-                    cert.checkValidity();
-                } catch (java.security.cert.CertificateNotYetValidException e) {
-                    throw new CertificateNotYetValidException(e.getMessage());
-                } catch (java.security.cert.CertificateExpiredException e) {
-                    throw new CertificateExpiredException(e.getMessage());
-                }
-            }
-
-            public void checkValidity(Date date) 
-                            throws CertificateExpiredException,
-                                   CertificateNotYetValidException {
-                try {
-                    cert.checkValidity(date);
-                } catch (java.security.cert.CertificateNotYetValidException e) {
-                    throw new CertificateNotYetValidException(e.getMessage());
-                } catch (java.security.cert.CertificateExpiredException e) {
-                    throw new CertificateExpiredException(e.getMessage());
-                }
-            }
-
-            public int getVersion() {
-                return 2;
-            }
-
-            public BigInteger getSerialNumber() {
-                return cert.getSerialNumber();
-            }
-
-            public Principal getIssuerDN() {
-                return cert.getIssuerDN();
-            }
-
-            public Principal getSubjectDN() {
-                return cert.getSubjectDN();
-            }
-
-            public Date getNotBefore() {
-                return cert.getNotBefore();
-            }
-
-            public Date getNotAfter() {
-                return cert.getNotAfter();
-            }
-
-            public String getSigAlgName() {
-                return cert.getSigAlgName();
-            }
-
-            public String getSigAlgOID() {
-                return cert.getSigAlgOID();
-            }
-
-            public byte[] getSigAlgParams() {
-                return cert.getSigAlgParams();
-            }
-        };
-    }
-
-    /**
-     * @com.intel.drl.spec_ref
-     */
-    public static final X509Certificate getInstance(byte[] certData)
-                                             throws CertificateException {
-        ByteArrayInputStream bais = new ByteArrayInputStream(certData);
-        return getInstance(bais);
-    }
-
-    /**
-     * @com.intel.drl.spec_ref
-     */
-    public abstract void checkValidity()
-            throws CertificateExpiredException, CertificateNotYetValidException;
-
-
-    /**
-     * @com.intel.drl.spec_ref
-     */
-    public abstract void checkValidity(Date date)
-            throws CertificateExpiredException, CertificateNotYetValidException;
-
-    /**
-     * @com.intel.drl.spec_ref
-     */
-    public abstract int getVersion();
-
-    /**
-     * @com.intel.drl.spec_ref
-     */
-    public abstract BigInteger getSerialNumber();
-
-    /**
-     * @com.intel.drl.spec_ref
-     */
-    public abstract Principal getIssuerDN();
-
-    /**
-     * @com.intel.drl.spec_ref
-     */
-    public abstract Principal getSubjectDN();
-
-    /**
-     * @com.intel.drl.spec_ref
-     */
-    public abstract Date getNotBefore();
-
-    /**
-     * @com.intel.drl.spec_ref
-     */
-    public abstract Date getNotAfter();
-
-    /**
-     * @com.intel.drl.spec_ref
-     */
-    public abstract String getSigAlgName();
-
-    /**
-     * @com.intel.drl.spec_ref
-     */
-    public abstract String getSigAlgOID();
-
-    /**
-     * @com.intel.drl.spec_ref
-     */
-    public abstract byte[] getSigAlgParams();
-}
-
+/*
+ *  Copyright 2005 The Apache Software Foundation or its licensors, as applicable.
+ *
+ *  Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+
+/**
+* @author Alexander Y. Kleymenov
+* @version $Revision$
+*/
+
+package javax.security.cert;
+
+import java.io.ByteArrayInputStream;
+import java.io.InputStream;
+import java.lang.reflect.Constructor;
+import java.math.BigInteger;
+import java.security.AccessController;
+import java.security.InvalidKeyException;
+import java.security.NoSuchAlgorithmException;
+import java.security.NoSuchProviderException;
+import java.security.Principal;
+import java.security.PublicKey;
+import java.security.Security;
+import java.security.SignatureException;
+import java.security.cert.CertificateFactory;
+import java.util.Date;
+import javax.security.cert.Certificate;
+import javax.security.cert.CertificateEncodingException;
+import javax.security.cert.CertificateException;
+import javax.security.cert.CertificateExpiredException;
+import javax.security.cert.CertificateNotYetValidException;
+
+/**
+ * @com.intel.drl.spec_ref
+ */
+public abstract class X509Certificate extends Certificate {
+
+    private static Constructor constructor;
+    
+    static {
+        try {
+            String classname = (String) AccessController.doPrivileged(
+                new java.security.PrivilegedAction() {
+                    public Object run() {
+                        return Security.getProperty("cert.provider.x509v1");
+                    }
+                }
+            );
+            Class cl = Class.forName(classname);
+            constructor =
+                cl.getConstructor(new Class[] {InputStream.class});
+        } catch (Throwable e) {
+        }
+    }
+    
+    /**
+     * @com.intel.drl.spec_ref
+     */
+    public X509Certificate() {
+        super();
+    }
+
+    /**
+     * @com.intel.drl.spec_ref
+     */
+    public static final X509Certificate getInstance(InputStream inStream)
+                                             throws CertificateException {
+        if (inStream == null) {
+            throw new CertificateException("The stream should not be null");
+        }
+        if (constructor != null) {
+            try {
+                return (X509Certificate) 
+                    constructor.newInstance(new Object[] {inStream});
+            } catch (Throwable e) {
+                throw new CertificateException(e.getMessage());
+            }
+        }
+
+        final java.security.cert.X509Certificate cert;
+        try {
+            CertificateFactory cf = CertificateFactory.getInstance("X.509");
+            cert = (java.security.cert.X509Certificate)
+                                            cf.generateCertificate(inStream);
+        } catch (java.security.cert.CertificateException e) {
+            throw new CertificateException(e.getMessage());
+        }
+
+        return new X509Certificate() {
+
+            public byte[] getEncoded() throws CertificateEncodingException {
+                try {
+                    return cert.getEncoded();
+                } catch (java.security.cert.CertificateEncodingException e) {
+                    throw new CertificateEncodingException(e.getMessage());
+                }
+            }
+
+            public void verify(PublicKey key) throws CertificateException,
+                                NoSuchAlgorithmException, InvalidKeyException,
+                                NoSuchProviderException, SignatureException {
+                try {
+                    cert.verify(key);
+                } catch (java.security.cert.CertificateException e) {
+                    throw new CertificateException(e.getMessage());
+                }
+            }
+
+            public void verify(PublicKey key, String sigProvider)
+                            throws CertificateException,
+                                NoSuchAlgorithmException, InvalidKeyException,
+                                NoSuchProviderException, SignatureException {
+                try {
+                    cert.verify(key, sigProvider);
+                } catch (java.security.cert.CertificateException e) {
+                    throw new CertificateException(e.getMessage());
+                }
+            }
+
+            public String toString() {
+                return cert.toString();
+            }
+
+            public PublicKey getPublicKey() {
+                return cert.getPublicKey();
+            }
+
+            public void checkValidity() throws CertificateExpiredException,
+                                   CertificateNotYetValidException {
+                try {
+                    cert.checkValidity();
+                } catch (java.security.cert.CertificateNotYetValidException e) {
+                    throw new CertificateNotYetValidException(e.getMessage());
+                } catch (java.security.cert.CertificateExpiredException e) {
+                    throw new CertificateExpiredException(e.getMessage());
+                }
+            }
+
+            public void checkValidity(Date date) 
+                            throws CertificateExpiredException,
+                                   CertificateNotYetValidException {
+                try {
+                    cert.checkValidity(date);
+                } catch (java.security.cert.CertificateNotYetValidException e) {
+                    throw new CertificateNotYetValidException(e.getMessage());
+                } catch (java.security.cert.CertificateExpiredException e) {
+                    throw new CertificateExpiredException(e.getMessage());
+                }
+            }
+
+            public int getVersion() {
+                return 2;
+            }
+
+            public BigInteger getSerialNumber() {
+                return cert.getSerialNumber();
+            }
+
+            public Principal getIssuerDN() {
+                return cert.getIssuerDN();
+            }
+
+            public Principal getSubjectDN() {
+                return cert.getSubjectDN();
+            }
+
+            public Date getNotBefore() {
+                return cert.getNotBefore();
+            }
+
+            public Date getNotAfter() {
+                return cert.getNotAfter();
+            }
+
+            public String getSigAlgName() {
+                return cert.getSigAlgName();
+            }
+
+            public String getSigAlgOID() {
+                return cert.getSigAlgOID();
+            }
+
+            public byte[] getSigAlgParams() {
+                return cert.getSigAlgParams();
+            }
+        };
+    }
+
+    /**
+     * @com.intel.drl.spec_ref
+     */
+    public static final X509Certificate getInstance(byte[] certData)
+                                             throws CertificateException {
+        if (certData == null) {
+            throw new CertificateException("The data should not be null");
+        }
+        ByteArrayInputStream bais = new ByteArrayInputStream(certData);
+        return getInstance(bais);
+    }
+
+    /**
+     * @com.intel.drl.spec_ref
+     */
+    public abstract void checkValidity()
+            throws CertificateExpiredException, CertificateNotYetValidException;
+
+
+    /**
+     * @com.intel.drl.spec_ref
+     */
+    public abstract void checkValidity(Date date)
+            throws CertificateExpiredException, CertificateNotYetValidException;
+
+    /**
+     * @com.intel.drl.spec_ref
+     */
+    public abstract int getVersion();
+
+    /**
+     * @com.intel.drl.spec_ref
+     */
+    public abstract BigInteger getSerialNumber();
+
+    /**
+     * @com.intel.drl.spec_ref
+     */
+    public abstract Principal getIssuerDN();
+
+    /**
+     * @com.intel.drl.spec_ref
+     */
+    public abstract Principal getSubjectDN();
+
+    /**
+     * @com.intel.drl.spec_ref
+     */
+    public abstract Date getNotBefore();
+
+    /**
+     * @com.intel.drl.spec_ref
+     */
+    public abstract Date getNotAfter();
+
+    /**
+     * @com.intel.drl.spec_ref
+     */
+    public abstract String getSigAlgName();
+
+    /**
+     * @com.intel.drl.spec_ref
+     */
+    public abstract String getSigAlgOID();
+
+    /**
+     * @com.intel.drl.spec_ref
+     */
+    public abstract byte[] getSigAlgParams();
+}
+

Modified: incubator/harmony/enhanced/classlib/trunk/modules/security/src/test/api/java/org/apache/harmony/security/tests/javax/security/cert/X509CertificateTest.java
URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/security/src/test/api/java/org/apache/harmony/security/tests/javax/security/cert/X509CertificateTest.java?rev=420819&r1=420818&r2=420819&view=diff
==============================================================================
--- incubator/harmony/enhanced/classlib/trunk/modules/security/src/test/api/java/org/apache/harmony/security/tests/javax/security/cert/X509CertificateTest.java (original)
+++ incubator/harmony/enhanced/classlib/trunk/modules/security/src/test/api/java/org/apache/harmony/security/tests/javax/security/cert/X509CertificateTest.java Tue Jul 11 05:29:54 2006
@@ -22,6 +22,7 @@
 package org.apache.harmony.security.tests.javax.security.cert;
 
 import java.io.ByteArrayInputStream;
+import java.io.InputStream;
 import java.security.cert.CertificateFactory;
 import java.util.Arrays;
 import java.util.Calendar;
@@ -115,6 +116,12 @@
             // The requested certificate type is not available.
             // Test pass..
         }
+        // Regression for HARMONY-756
+		try {
+			X509Certificate.getInstance((InputStream) null);
+		} catch (CertificateException e) {
+			//expected;
+		}
     }
 
     /**
@@ -135,6 +142,12 @@
             // The requested certificate type is not available.
             // Test pass..
         }
+   		// Regression for HARMONY-756
+		try {
+			X509Certificate.getInstance((byte[]) null);
+		} catch (CertificateException e) {
+			//expected;
+		}
     }
 
     /**