Return-Path: Delivered-To: apmail-incubator-harmony-commits-archive@www.apache.org Received: (qmail 84161 invoked from network); 5 Jul 2006 09:55:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 5 Jul 2006 09:55:18 -0000 Received: (qmail 32238 invoked by uid 500); 5 Jul 2006 09:55:18 -0000 Delivered-To: apmail-incubator-harmony-commits-archive@incubator.apache.org Received: (qmail 32146 invoked by uid 500); 5 Jul 2006 09:55:17 -0000 Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-commits@incubator.apache.org Received: (qmail 32133 invoked by uid 99); 5 Jul 2006 09:55:17 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Jul 2006 02:55:17 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Jul 2006 02:55:17 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 78D484103DE for ; Wed, 5 Jul 2006 09:53:30 +0000 (GMT) Message-ID: <16567360.1152093210492.JavaMail.jira@brutus> Date: Wed, 5 Jul 2006 09:53:30 +0000 (GMT+00:00) From: "George Harley (JIRA)" To: harmony-commits@incubator.apache.org Subject: [jira] Closed: (HARMONY-738) [classlib][nio] Refine two unstable tests in o.a.h.tests.java.nio.channels.SourceChannelTest In-Reply-To: <11455488.1151994509772.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/HARMONY-738?page=all ] George Harley closed HARMONY-738: --------------------------------- Verified by Andrew. > [classlib][nio] Refine two unstable tests in o.a.h.tests.java.nio.channels.SourceChannelTest > -------------------------------------------------------------------------------------------- > > Key: HARMONY-738 > URL: http://issues.apache.org/jira/browse/HARMONY-738 > Project: Harmony > Type: Test > Components: Classlib > Reporter: Andrew Zhang > Assignee: George Harley > Attachments: nio.diff > > Refine two unstable tests in o.a.h.tests.java.nio.channels.SourceChannelTest. > They are test_read_$LByteBuffer(), test_read_$LByteBufferII(). > Following code doesn't ensure all data are read in blocking mode: > do { > long count = source.read(readBufArray, 0, 2); > if (count < 0) { > break; > } > totalCount += count; > } while (totalCount != 10 && !isBlocking); > Also, sink.close() should be invoked to ensure that all data are sent. > I'll upload a patch soon. > Thanks! > Best regards, > Andrew -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira