Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Message-ID: <10968449.1153458974792.JavaMail.jira@brutus>
Date: Thu, 20 Jul 2006 22:16:14 -0700 (PDT)
From: "Nathan Beyer (JIRA)" <jira@apache.org>
To: harmony-commits@incubator.apache.org
Subject: [jira] Commented: (HARMONY-883) [classlib][sound] First
 contribution: javax.sound.midi interfaces
In-Reply-To: <1357977.1153035073943.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/HARMONY-883?page=comments#action_12422548 ] 
            
Nathan Beyer commented on HARMONY-883:
--------------------------------------

The MidiMessageTest is the only test that's currently passing. All of the others are failing. Note: the tests all pass when run against a RI JRE, but not when run against the submitted classes.

Also, the implementation of the tests doesn't appropriate use the JUnit assertion methods. Every assertion is performed using the 'assertTrue'. Please try to use 'assertEquals', 'assertNull', etc. These methods provide must more information when the test fail.

> [classlib][sound] First contribution: javax.sound.midi interfaces
> -----------------------------------------------------------------
>
>                 Key: HARMONY-883
>                 URL: http://issues.apache.org/jira/browse/HARMONY-883
>             Project: Harmony
>          Issue Type: New Feature
>            Reporter: Evgeny S. Sidorenko
>         Assigned To: Nathan Beyer
>         Attachments: sound.midi.patch.txt, update.patch..txt
>
>
> Patch with all interfaces from package javax.sound.midi

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira