Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Message-ID: <10326976.1153457475306.JavaMail.jira@brutus>
Date: Thu, 20 Jul 2006 21:51:15 -0700 (PDT)
From: "Mikhail Loenko (JIRA)" <jira@apache.org>
To: harmony-commits@incubator.apache.org
Subject: [jira] Resolved: (HARMONY-924) [classlib][beans] some tests from
 ExpressionTest class fail
In-Reply-To: <30335382.1153316893950.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

     [ http://issues.apache.org/jira/browse/HARMONY-924?page=all ]

Mikhail Loenko resolved HARMONY-924.
------------------------------------

    Resolution: Fixed

fixed in revision 424177
Alexei please check that it was applied as expected

> [classlib][beans] some tests from ExpressionTest class fail
> -----------------------------------------------------------
>
>                 Key: HARMONY-924
>                 URL: http://issues.apache.org/jira/browse/HARMONY-924
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: winXP
>            Reporter: Alexei Zakharov
>         Assigned To: Mikhail Loenko
>         Attachments: ExpressionTest.patch
>
>
> Currently 23 out of 56 tests from org.apache.harmony.beans.tests.java.beans.ExpressionTest class fail due various reasons.  Attached patch corrects following invalid tests:
> testConstructor_Normal took
> testConstructor_NullTarget took
> testConstructor_ArrayTarget took
> testConstructor_NullMethodName
> testConstructor_NewMethodName
> testConstructor_EmptyMethodName
> testConstructor_NullArguments took
> testConstructor_NullArgument took
> testConstructor_Value_Normal took
> testConstructor_Value_NullTarget took
> testConstructor_Value_ArrayTarget took
> testConstructor_Value_NullMethodName took 
> testConstructor_Value_NewMethodName took
> testConstructor_Value_EmptyMethodName took
> testConstructor_Value_NullArguments took
> testConstructor_Value_NullArgument took
> testConstructor_Value_NullValue took
> These tests fail on RI also.
> Change log:
> 1. All tests above checked for invalid toString() patterns. Corrected. Now it checks for patterns returned by RI. 
> 2. Some tests constructed Expression without return value specified and then called toString(). Both our implementation and RI execute the expression in this case to obtain the return value. But it seems these tests didn't expect Statement.execute() method to be called and didn't pass valid parameters to Statement constructs, just stubs. This situation has been correct.
> 3. For some tests calling toString is an invalid action at all. I have just removed this assertion for these tests.
> As a result all tests mentioned above pass on our implementation as well as on RI.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira