Return-Path: Delivered-To: apmail-incubator-harmony-commits-archive@www.apache.org Received: (qmail 37052 invoked from network); 6 Jul 2006 09:16:20 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 6 Jul 2006 09:16:20 -0000 Received: (qmail 82259 invoked by uid 500); 6 Jul 2006 09:16:20 -0000 Delivered-To: apmail-incubator-harmony-commits-archive@incubator.apache.org Received: (qmail 82168 invoked by uid 500); 6 Jul 2006 09:16:20 -0000 Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-commits@incubator.apache.org Received: (qmail 82157 invoked by uid 99); 6 Jul 2006 09:16:19 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Jul 2006 02:16:19 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Jul 2006 02:16:19 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 197CF410412 for ; Thu, 6 Jul 2006 09:14:31 +0000 (GMT) Message-ID: <10149104.1152177271101.JavaMail.jira@brutus> Date: Thu, 6 Jul 2006 09:14:31 +0000 (GMT+00:00) From: "Andrew Zhang (JIRA)" To: harmony-commits@incubator.apache.org Subject: [jira] Updated: (HARMONY-779) [classlib][nio] Refine several methods of o.a.h.nio.internal.DatagramChannelImpl In-Reply-To: <6193692.1152171149765.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/HARMONY-779?page=all ] Andrew Zhang updated HARMONY-779: --------------------------------- Attachment: nio.diff Hello, Would you please try my patch? For item1 mentioned in previous description, the patch also removes a unnecessary catch block since this exception would never be thrown if implConfigureBlocking does nothing. Thanks! Best regards, Andrew > [classlib][nio] Refine several methods of o.a.h.nio.internal.DatagramChannelImpl > -------------------------------------------------------------------------------- > > Key: HARMONY-779 > URL: http://issues.apache.org/jira/browse/HARMONY-779 > Project: Harmony > Type: Improvement > Components: Classlib > Reporter: Andrew Zhang > Attachments: nio.diff > > Refine several methods of o.a.h.nio.internal.DatagramChannelImpl. The improvements include: > 1. implConfgiureBlocking method: Remove an unnecessary operation as discussed on mailing-list. [1] > 2. Change ArrayIndexOutOfBoundsException to IndexOutOfBoundsException in read/write methods as spec specifies and RI also > throws IndexOutOfBoundsException. > 3. Delete some unnecessary comment-out codes. > I'll upload a patch soon. > Thanks! > Best regards, > Andrew -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira