From harmony-commits-return-8201-apmail-incubator-harmony-commits-archive=incubator.apache.org@incubator.apache.org Tue Jul 25 13:12:37 2006 Return-Path: Delivered-To: apmail-incubator-harmony-commits-archive@www.apache.org Received: (qmail 90487 invoked from network); 25 Jul 2006 13:12:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 25 Jul 2006 13:12:36 -0000 Received: (qmail 27762 invoked by uid 500); 25 Jul 2006 13:12:36 -0000 Delivered-To: apmail-incubator-harmony-commits-archive@incubator.apache.org Received: (qmail 27724 invoked by uid 500); 25 Jul 2006 13:12:35 -0000 Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-commits@incubator.apache.org Received: (qmail 27713 invoked by uid 99); 25 Jul 2006 13:12:35 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Jul 2006 06:12:35 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Jul 2006 06:12:35 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id A5CCB714283 for ; Tue, 25 Jul 2006 13:10:15 +0000 (GMT) Message-ID: <31767204.1153833015676.JavaMail.jira@brutus> Date: Tue, 25 Jul 2006 06:10:15 -0700 (PDT) From: "Alexei Zakharov (JIRA)" To: harmony-commits@incubator.apache.org Subject: [jira] Commented: (HARMONY-966) [classlib][beans] final fixes for ExpressionTest (2) In-Reply-To: <17172008.1153759333911.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/HARMONY-966?page=comments#action_12423331 ] Alexei Zakharov commented on HARMONY-966: ----------------------------------------- Mikail, thanks, the patch is applied as expected. About failures on RI - everything pass on my jdk.1.5.0_05. However, one test fails on jrockit-R26.3.0-jdk1.5.0_06. What are names of the tests that fail on your machine? > [classlib][beans] final fixes for ExpressionTest (2) > ---------------------------------------------------- > > Key: HARMONY-966 > URL: http://issues.apache.org/jira/browse/HARMONY-966 > Project: Harmony > Issue Type: Improvement > Components: Classlib > Environment: WinXP > Reporter: Alexei Zakharov > Assigned To: Mikhail Loenko > Attachments: ExpressionTest2.patch > > > The following previously failed tests are affected by the attached patch: > testGetValue_UnboundedNullMethodName > This test checks if NoSuchMethodException is thrown. But both RI and our implementation throws NullPointerException in this case. So I have changed the test to check for NullPointerException. > testGetValue_UnboundedOverloadedMethodsNull > fails on RI also, tests the order of elements returned by Class.getMethods(), Removed. > testGetValue_UnboundedOverloadedConstructorsNull > invalid test, fails on RI. Removed. > testGetValue_UnboundedClassForName > Bug in test - tries to call Class.forName() for class loaded by another class loader. Corrected. > testConstructor_Value_SetValueCalledIn > Tests implementation specific details of the third-party implementation. Fails on RI also. REmoved. > This is the final fix for ExpressionsTest class from me. Now all tests from this class pass on the our implementation as well as on RI. We can finally remove this class from the exclude list. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira