harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HARMONY-722) [classlib][beans] some tests from StatementTest fails
Date Mon, 03 Jul 2006 12:44:30 GMT
     [ http://issues.apache.org/jira/browse/HARMONY-722?page=all ]
     
Tim Ellison resolved HARMONY-722:
---------------------------------

    Resolution: Fixed
     Assign To: Tim Ellison

Thanks Alexei,

A slightly modified version of your patch was applied to the BEANS module at repo revision
r418756.

The tests were tweaked so they let some exceptions escape to the JUnit framework (rather than
be caught and assertTrue(false)).

Please check that you patch was applied correctly.


> [classlib][beans] some tests from StatementTest fails
> -----------------------------------------------------
>
>          Key: HARMONY-722
>          URL: http://issues.apache.org/jira/browse/HARMONY-722
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>  Environment: winXP
>     Reporter: Alexei Zakharov
>     Assignee: Tim Ellison
>  Attachments: StatementTest.patch
>
> Currently 20 of 50 tests from org.apache.harmony.beans.tests.java.beans.StatementTest
class fail. I have created a patch to enable another 9 tests. Please see details below. 
> -testExceptionThrownOnMethodCall 
> The test Bean was implemented incorrectly. This test fails on RI also. The bean was corrected.
> -testConstructor_Normal
> -testConstructor_NullTarget
> -testConstructor_ArrayTarget
> -testConstructor_NullMethodName
> -testConstructor_NewMethodName
> -testConstructor_EmptyMethodName
> -testConstructor_NullArguments
> -testConstructor_NullArgument
> Fail on RI also. Specific implementation of Statement.toString() method was being checked.
I replaced it with checking of our implementation. Our toString() was fixed to correspond
with RI beforehand. I have started the new mail thread in the list concerning do we need to
care about toString compatibility in the future.
> -testGetArguments
> -testGetMethodName
> -testGetTarget
> -testToString
> I commented 'em out since they are empty.
>  
> testExecute_NullMethodName
> Invalid test, I commented it out. It fails on RI also. Method name should not be null.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message