harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Loenko (JIRA)" <j...@apache.org>
Subject [jira] Closed: (HARMONY-673) perf improving for util.logging.Logger
Date Mon, 31 Jul 2006 05:44:15 GMT
     [ http://issues.apache.org/jira/browse/HARMONY-673?page=all ]

Mikhail Loenko closed HARMONY-673.
----------------------------------


no complaints, assuming it's OK

> perf improving for util.logging.Logger
> --------------------------------------
>
>                 Key: HARMONY-673
>                 URL: http://issues.apache.org/jira/browse/HARMONY-673
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Rustem Rafikov
>         Assigned To: Mikhail Loenko
>            Priority: Minor
>         Attachments: logging.patch, LogPerfTest.java
>
>
> I would like to suggest a patch improving performance of util.logging.Logger.
> Summary of changes:
> 1. Frequently (on each logging call) used internalIsLoggable method became not synchronized
and not  "walking" through parents if a logger should inherit a parent level. As setLevel
occures much rarely than log call it is preferable to inherit a parent level when setting
a parent and when changing a parent. internalIsLoggable uses int value of log level to avoid
extra call to Level.intValue() method.
> 2. Main log method uses getHandlers returning array of handlers on each logging call.
So, handlers.toArray(new Handler[0]) has been changed to handlers.toArray(new Handler[handlers.size()])
to avoid excessive creation of the array. It is much faster.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message