harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stepan Mishura (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-975) [classlib][beans] fixes for DefaultPersistenceDelegateTest failures (1)
Date Mon, 31 Jul 2006 13:27:14 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-975?page=comments#action_12424537 ] 
            
Stepan Mishura commented on HARMONY-975:
----------------------------------------

Alexei,

I've run the test on SUN JRE 1.4.2 and BEA JRockit 1.5 and test cases you have mentioned passed
for me (except testInstantiate_EmptyProperty). So it is not clear for me why you believe that
they are invalid.

Thanks,
Stepan.

> [classlib][beans] fixes for DefaultPersistenceDelegateTest failures (1)
> -----------------------------------------------------------------------
>
>                 Key: HARMONY-975
>                 URL: http://issues.apache.org/jira/browse/HARMONY-975
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: winXP
>            Reporter: Alexei Zakharov
>         Attachments: DefailtPersistenceDelegateTest.patch
>
>
> Currently 19 tests from org.apache.harmony.beans.tests.java.beans.DefaultPersistenceDelegateTest
class fail due various reasons. The attached patch corrects some of these failures. Please
see the list of affected tests below.
> testInstantiate_NullProperty
> testInstantiate_EmptyProperty
> testInstantiate_NonExistingGetterNullEncoder
> Invalid tests indeed. Fail if NullPointerException isn't thrown. Neither RI nor our implementation
throws such exception here. Corrected. 
> testInstantiate_NonExistingGetter
> testInstantiate_NoGetter
> Are also invalid tests. They test the behavior that is specific to some third-party implementation
of beans (not RI). I corrected the sophisticated but invalid exception handling I've found
in these tests. Now it reflects the RI behavior. Please note that using of singleton class
CallVerificationStack is thread unsafe here. I have replaced CallVerificationStack with locally
defined variable.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message