harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Zhang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-860) [classlib][nio] Remove some unnecessary codes and a FIXME from o.a.h.nio.internal.DatagramChannelImpl
Date Mon, 17 Jul 2006 01:51:15 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-860?page=comments#action_12421497 ] 
            
Andrew Zhang commented on HARMONY-860:
--------------------------------------

Hi George,

The fix looks good, thanks!

Best regards,
Andrew

> [classlib][nio] Remove some unnecessary codes and a FIXME from o.a.h.nio.internal.DatagramChannelImpl
> -----------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-860
>                 URL: http://issues.apache.org/jira/browse/HARMONY-860
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Andrew Zhang
>         Assigned To: George Harley
>            Priority: Minor
>         Attachments: DatagramChannelImpl.diff
>
>
> There are some unnecessary codes in o.a.h.nio.internal.DatagramChannelImpl, includes:
> 1. duplicate exception check
> 2. an unnecessary FIXME which has been discussed on mailing list. [1] 
> I'll upload a patch to remove them. 
> Thanks!
> [1] thread: Peek on DatagramChannel.receive(ByteBuffer)?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message