harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulex Yang (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HARMONY-914) [classlib][nio] refine o.a.h.nio.SocketChannelImpl
Date Wed, 19 Jul 2006 10:24:15 GMT
     [ http://issues.apache.org/jira/browse/HARMONY-914?page=all ]

Paulex Yang resolved HARMONY-914.
---------------------------------

    Resolution: Fixed

Patch applied at revision r423423, thanks a lot for this enhancement, please verify that the
problem is fully fixed as you expected.

However, I have some comments on this issue, the SocketAddress is not guaranteed to has valid
port, because it is public abstract class and can be extended. But the patch is still valid,
because SocketChannel.connect() only actually accepts InetSocketAddress, otherwise it will
throw UnsupportedAddressTypeException, further the InetSocketAddress has no way to have a
invalid port.

> [classlib][nio] refine o.a.h.nio.SocketChannelImpl
> --------------------------------------------------
>
>                 Key: HARMONY-914
>                 URL: http://issues.apache.org/jira/browse/HARMONY-914
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Andrew Zhang
>         Assigned To: Paulex Yang
>         Attachments: SocketChannelImpl.diff
>
>
> Hello,
>      SocketChannelImpl.connect(SocketAddress socketAddress) checks whether
> socketAddress.getPort() is illegal. This is unnecessary as we can not create a SocketAddress
> with an illegal port number.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message