harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Zakharov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-820) [classlib][beans] beautifying of java.beans classes (2)
Date Tue, 11 Jul 2006 09:43:30 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-820?page=comments#action_12420263 ] 

Alexei Zakharov commented on HARMONY-820:
-----------------------------------------

Hi Mikhail,

There are still some violations in the code. Of course if we are talking about Sun CC. Please
see below.

Encoder.java
35 too long line (> 80 symbols) [1]
120 no new line after variable declaration  [2]
122,206 declaration not at the begining of the block [3]

EventHandler.java
60 declaration not at the begining of the block [3]

With Best Regards,
Alexei

[1] http://java.sun.com/docs/codeconv/html/CodeConventions.doc3.html#313
[2] http://java.sun.com/docs/codeconv/html/CodeConventions.doc7.html#487
[3] http://java.sun.com/docs/codeconv/html/CodeConventions.doc5.html#16817


> [classlib][beans] beautifying of java.beans classes (2)
> -------------------------------------------------------
>
>          Key: HARMONY-820
>          URL: http://issues.apache.org/jira/browse/HARMONY-820
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>  Environment: winXP
>     Reporter: Alexei Zakharov
>     Assignee: Mikhail Loenko
>     Priority: Trivial
>  Attachments: java_beans_style2.patch
>
> I applied Sun code conventions to following classes from java.beans package:
> Encoder
> EventHandler
> EventSetDescriptor
> List of changes:
> 1. Insert blank line before beginning of new block 
> 2. White space after if, while etc. 
> 3. Wrap lines longer than 80 characters 
> 4. All variables are defined at the beginning of the block 
> 5. Blank line after variable declaration block 
> etc.
> Please see the patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message