harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geir Magnusson Jr (JIRA)" <j...@apache.org>
Subject [jira] Assigned: (HARMONY-9) Use of memcpy() in copying portions of class file attribute structures
Date Wed, 19 Jul 2006 14:39:20 GMT
     [ http://issues.apache.org/jira/browse/HARMONY-9?page=all ]

Geir Magnusson Jr reassigned HARMONY-9:
---------------------------------------

    Assignee: Daniel Lydick  (was: Geir Magnusson Jr)

> Use of memcpy() in copying portions of class file attribute structures
> ----------------------------------------------------------------------
>
>                 Key: HARMONY-9
>                 URL: http://issues.apache.org/jira/browse/HARMONY-9
>             Project: Harmony
>          Issue Type: Bug
>          Components: VM
>         Environment: All little-endian environments, but properly all environments
>            Reporter: Bootstrap JVM (Daniel Lydick)
>         Assigned To: Daniel Lydick
>
> Geir points out in SVN 312652 that,
>     "I don't agree... things need to be byteswapped for indices and such"
> for copying the final portions of a (attribute_info) structure from the class file
> input buffer into the JVM runtime structure.  He comments elsewhere about
> the need to byte swap one particular field, and added code to do this, but
> his observation here is directly relevant to all fields on a little-endian architecture.
> Sorry about that.  I became so focused on the normative functionality for big-endian
> environments that I forgot about this issue while working on this area.  The approach
> used in his implementation of the (ConstantValue_attribute) should be applied to
> all fields of all attributes, and the memcpy() below his comment needs to be undone
> in favor of this approach for all cases of all attributes.  This is the more correct
> approach.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message