harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Zhang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1004) [classlib][nio] Remove two magic numbers from o.a.h.tests.java.nio.channels.DatagramChannelTest
Date Tue, 01 Aug 2006 03:42:15 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1004?page=comments#action_12424723 ] 
            
Andrew Zhang commented on HARMONY-1004:
---------------------------------------

Hi Paulex,

The fix looks fine. Thanks!

Best regards,
Andrew

> [classlib][nio] Remove two magic numbers from o.a.h.tests.java.nio.channels.DatagramChannelTest
> -----------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1004
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1004
>             Project: Harmony
>          Issue Type: Test
>          Components: Classlib
>            Reporter: Andrew Zhang
>         Assigned To: Paulex Yang
>         Attachments: nio.diff
>
>
> Private methods assertSocketActionBeforeConnect(DatagramSocket s) and assertSocketActionAfterConnect(DatagramSocket
s) contain magic number , which may cause test fail because of port confliction. i.e. 
> "this.datagramSocket2 = new DatagramSocket(1082);"
> Addtionally, these magic numbers are not necessary at all.  
> I'll upload to fix this problem soon.
> Thanks!
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message