Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Message-ID: <33205539.1150853130164.JavaMail.jira@brutus>
Date: Wed, 21 Jun 2006 01:25:30 +0000 (GMT+00:00)
From: "Andrew Zhang (JIRA)" <jira@apache.org>
To: harmony-commits@incubator.apache.org
Subject: [jira] Commented: (HARMONY-616) Remove one FIXME from
 "receive(ByteBuffer)" method of
 org.apache.harmony.nio.internal.DatagramChannelImpl class.
In-Reply-To: <31026342.1150697609768.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/HARMONY-616?page=comments#action_12417008 ] 

Andrew Zhang commented on HARMONY-616:
--------------------------------------

Hi George,

The fix looks fine. Many thanks!

> Remove one FIXME from "receive(ByteBuffer)" method of org.apache.harmony.nio.internal.DatagramChannelImpl class.
> ----------------------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-616
>          URL: http://issues.apache.org/jira/browse/HARMONY-616
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Andrew Zhang
>     Assignee: George Harley
>     Priority: Minor
>  Attachments: harmony-616.diff
>
> If a DatagramSocket is unbound, receive(ByteBuffer) should return immediately, and the socket status remains unbound. Currently Harmony implementation is correct. I'll upload a patch to remove this FIXME and update corresponding test. Thanks.
> the FIXME in receive method:
>       if (!isBound) {
>             // FIXME RI seems does not perform as datagram socket
>             // SecurityManager security = System.getSecurityManager();
>             // if (security != null)
>             // security.checkListen(0);
>             // final byte[] any = new byte[] { 0, 0, 0, 0 };
>             // try {
>             // networkSystem.bind(fd, 0, InetAddress.getByAddress(any));
>             // } catch (UnknownHostException e) {
>             // // impossible,do nothing
>             // }
>             // isBound = true;
>             return null;
>         }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira