Return-Path: Delivered-To: apmail-incubator-harmony-commits-archive@www.apache.org Received: (qmail 54579 invoked from network); 2 Jun 2006 10:21:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 2 Jun 2006 10:21:25 -0000 Received: (qmail 6027 invoked by uid 500); 2 Jun 2006 10:21:25 -0000 Delivered-To: apmail-incubator-harmony-commits-archive@incubator.apache.org Received: (qmail 5939 invoked by uid 500); 2 Jun 2006 10:21:24 -0000 Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-commits@incubator.apache.org Received: (qmail 5927 invoked by uid 99); 2 Jun 2006 10:21:24 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jun 2006 03:21:24 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jun 2006 03:21:24 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 2A02F7141E4 for ; Fri, 2 Jun 2006 10:20:30 +0000 (GMT) Message-ID: <29002803.1149243630142.JavaMail.jira@brutus> Date: Fri, 2 Jun 2006 10:20:30 +0000 (GMT+00:00) From: "Paulex Yang (JIRA)" To: harmony-commits@incubator.apache.org Subject: [jira] Updated: (HARMONY-550) [classlib][nio-channels]Multiple bugs in org.apache.harmony.tests.java.nio.ByteBufferTest In-Reply-To: <17951844.1149220470716.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/HARMONY-550?page=all ] Paulex Yang updated HARMONY-550: -------------------------------- Attachment: Harmony550.diff Please try this patch, thank you. > [classlib][nio-channels]Multiple bugs in org.apache.harmony.tests.java.nio.ByteBufferTest > ----------------------------------------------------------------------------------------- > > Key: HARMONY-550 > URL: http://issues.apache.org/jira/browse/HARMONY-550 > Project: Harmony > Type: Bug > Components: Classlib > Reporter: Paulex Yang > Priority: Minor > Attachments: Harmony550.diff > > 1. Several "Arrays.equals(arg1, arg2)" in the testAsShortBuffer, testAsLongBuffer and testAsIntBuffer method miss assertTrue() statement. > 2. When the missed asserts are added, four more test cases fail on Harmony, look more inside, the evil is not in the ByteBuffer but in the helper methods of ByteBufferTest - short2bytes, int2bytes(int value, ByteOrder order) and long2bytes(long value, ByteOrder order), These methods try to convert a short/long/int value to byte arrays with the given ByteOrder, but if the ByteOrder is set to ByteOrder.LITTLE_ENDIAN, an error may occur. For example, a short value 0x0102 should be converted to byte[2]{02,01} with ByteOrder.LITTLE_ENDIAN, but it returns byte[2]{01,00} now. I will attach patch soon. > The test result keep same on RI before and after these bug fixing. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira