Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Message-ID: <28958244.1150711830640.JavaMail.jira@brutus>
Date: Mon, 19 Jun 2006 10:10:30 +0000 (GMT+00:00)
From: "Paulex Yang (JIRA)" <jira@apache.org>
To: harmony-commits@incubator.apache.org
Subject: [jira] Commented: (HARMONY-618)
 [classlib][nio]java.nio.channels.nio.SelectorProvider should not use
 thread's context classloader to load provider class defined in property
 file
In-Reply-To: <9108812.1150703849770.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/HARMONY-618?page=comments#action_12416730 ] 

Paulex Yang commented on HARMONY-618:
-------------------------------------

looks fine, thank you, Tim.

> [classlib][nio]java.nio.channels.nio.SelectorProvider should not use thread's context classloader to load provider class defined in property file
> -------------------------------------------------------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-618
>          URL: http://issues.apache.org/jira/browse/HARMONY-618
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Paulex Yang
>     Assignee: Tim Ellison
>     Priority: Minor
>  Attachments: Harmony-618.diff
>
> SelectorProvider.provider() should not use the Thread.currentThread().getContextClassLoader() to load the provider class defined in property file, test shows RI doesn't uses it.
> Run the test below, and 
> RI prints: pass
> while Harmony prints: fail
> public class SelectorProviderTest {
>     private static final Class CLASS1 = MockSelectorProvider1.class;
>     private static final Class CLASS2 = MockSelectorProvider2.class;
>     private static final String KEY = "java.nio.channels.spi.SelectorProvider";
>     public static void main(String[] args) {
>         System.setProperty(KEY, CLASS1.getName());
>         Thread.currentThread().setContextClassLoader(new MockClassLoader());
>         SelectorProvider provider = SelectorProvider.provider();
>         if (provider.getClass() == CLASS1) {
>             System.out.println("pass");
>         } else {
>             System.out.println("fail");
>         }
>     }
>     private static class MockClassLoader extends ClassLoader {
>         public Class<?> loadClass(String name) throws ClassNotFoundException {
>             return CLASS2;
>         }
>     }
>     
>     public static class MockSelectorProvider2 extends SelectorProvider{
>         public DatagramChannel openDatagramChannel() throws IOException {
>             return null;
>         }
>         public Pipe openPipe() throws IOException {
>             return null;
>         }
>         public AbstractSelector openSelector() throws IOException {
>             return null;
>         }
>         public ServerSocketChannel openServerSocketChannel() throws IOException {
>             return null;
>         }
>         public SocketChannel openSocketChannel() throws IOException {
>             return null;
>         }
>     }
>     public static class MockSelectorProvider1 extends SelectorProvider{
>         public DatagramChannel openDatagramChannel() throws IOException {
>             return null;
>         }
>         public Pipe openPipe() throws IOException {
>             return null;
>         }
>         public AbstractSelector openSelector() throws IOException {
>             return null;
>         }
>         public ServerSocketChannel openServerSocketChannel() throws IOException {
>             return null;
>         }
>         public SocketChannel openSocketChannel() throws IOException {
>             return null;
>         }
>     }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira