Return-Path: Delivered-To: apmail-incubator-harmony-commits-archive@www.apache.org Received: (qmail 26201 invoked from network); 27 Jun 2006 20:31:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 27 Jun 2006 20:31:09 -0000 Received: (qmail 95063 invoked by uid 500); 27 Jun 2006 20:31:08 -0000 Delivered-To: apmail-incubator-harmony-commits-archive@incubator.apache.org Received: (qmail 94976 invoked by uid 500); 27 Jun 2006 20:31:08 -0000 Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-commits@incubator.apache.org Received: (qmail 94965 invoked by uid 99); 27 Jun 2006 20:31:08 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jun 2006 13:31:08 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jun 2006 13:31:07 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 31DC57141F5 for ; Tue, 27 Jun 2006 20:29:33 +0000 (GMT) Message-ID: <17489409.1151440173201.JavaMail.jira@brutus> Date: Tue, 27 Jun 2006 20:29:33 +0000 (GMT+00:00) From: "George Harley (JIRA)" To: harmony-commits@incubator.apache.org Subject: [jira] Closed: (HARMONY-658) Remove an unstable test from DatagramChannelTest.java In-Reply-To: <7810682.1151292809763.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/HARMONY-658?page=all ] George Harley closed HARMONY-658: --------------------------------- Verified by Andrew. > Remove an unstable test from DatagramChannelTest.java > ----------------------------------------------------- > > Key: HARMONY-658 > URL: http://issues.apache.org/jira/browse/HARMONY-658 > Project: Harmony > Type: Test > Components: Classlib > Reporter: Andrew Zhang > Assignee: George Harley > Attachments: nio.diff > > Hello, > Consider following test from DatagramChannelTest.java, which is potentially unstable. > The test can not guarantee that channel1.receive always executes before channel1.close. > Therefore, the test may fail sometimes. > private void closeBlockedChannelForReceive(ByteBuffer dst) > throws IOException { > // TODO refine async close test when AbstractInterruptibleChannel > // complete > // to break the blocking status, let a thread to close this channel. > new Thread() { > public void run() { > try { > // Can not guarantee that channel1.receive always executes before channel1.close. > // Therefore, the test may fail. > Thread.sleep(TIME_UNIT); > channel1.close(); > } catch (Exception e) { > e.printStackTrace(); > } > } > }.start(); > try { > this.channel1.receive(dst); > fail("Should throw a AsynchronousCloseException"); > } catch (AsynchronousCloseException e) { > //expected > } > } > I'll remove the test from DatagramChannelTest.java. > Thanks! > Best regards, > Andrew -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira