[classlib][nio] Refactor ServerSocketAdapter.accept(Socket, SocketChannelImpl) in o.a.h.nio.internal.ServerSocketChannelImpl
------------------------------------------------------------------------------------------------------------------------------
Key: HARMONY-675
URL: http://issues.apache.org/jira/browse/HARMONY-675
Project: Harmony
Type: Bug
Components: Classlib
Reporter: Andrew Zhang
Priority: Minor
There are serveral problems in ServerSocketAdapter.accept(Socket, SocketChannelImpl) method:
1. The modifier should be private, not public. As spec says: "The returned object will not
declare any public methods that are not declared in the ServerSocket class."
2. One unnecessary FIXME.
3. Some unneccessray code.
I'll upload a patch soon. Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
|