harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oliver Deakin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-695) [classlib] Remove two unnecessary header files
Date Wed, 28 Jun 2006 18:01:33 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-695?page=comments#action_12418284 ] 

Oliver Deakin commented on HARMONY-695:
---------------------------------------

Looks good - thanks Mark.

> [classlib] Remove two unnecessary header files
> ----------------------------------------------
>
>          Key: HARMONY-695
>          URL: http://issues.apache.org/jira/browse/HARMONY-695
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Oliver Deakin
>     Assignee: Mark Hindess
>     Priority: Minor
>  Attachments: cleanup.unnecessary.headers.diff, cleanup.unnecessary.headers.sh
>
> native-src/shared/common/jcl.h and modules/luni/src/main/native/include/shared/hamony.h
are identical, and both basically just do:
> #define USING_VMI
> #include "vmi.h"
> This is pointless, since vmi.h is a shared header file (copied into deploy/include) at
build time anyway. I propose that these two header files are removed, and files that include
them are fixed up to include vmi.h instead.
> I will attach a patch to remove the files shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message