harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "George Harley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-691) [classlib][nio] Remove some unstable tests from o.a.h.tests.java.nio.channels.SocketChannelTest.
Date Thu, 29 Jun 2006 10:58:31 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-691?page=comments#action_12418436 ] 

George Harley commented on HARMONY-691:
---------------------------------------

Hi Andrew, 

You make very good points on the quality of these tests. If you would allow me to try and
summarise, it seems that you are highlighting two basic problems with them:

1) using stderr as a means of reporting potential failures while permitting the test to pass
is poor. 
2) the tests on non-blocking channels appear to be treating them in the same way as blocking
channels. Again this is poor. 

I agree that the tests under discussion should be re-written and will remove them for now
pending the submission of replacement tests.

Best regards, 
George



> [classlib][nio] Remove some unstable tests from o.a.h.tests.java.nio.channels.SocketChannelTest.
> ------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-691
>          URL: http://issues.apache.org/jira/browse/HARMONY-691
>      Project: Harmony
>         Type: Test

>   Components: Classlib
>     Reporter: Andrew Zhang
>     Assignee: George Harley
>  Attachments: nio.diff
>
> Hello, 
> I found some unstable tests in o.a.h.tests.java.nio.channels.SocketChannelTest. 
> I'll upload a patch to remove these unstable tests, and plan to add new stable tests
later  in a seperated JIRA. 
> Thanks!
> Best regards
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message