harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ndbe...@apache.org
Subject svn commit: r417146 - /incubator/harmony/enhanced/classlib/trunk/modules/nio/src/test/java/org/apache/harmony/tests/java/nio/channels/SocketChannelTest.java
Date Mon, 26 Jun 2006 08:58:41 GMT
Author: ndbeyer
Date: Mon Jun 26 01:58:40 2006
New Revision: 417146

URL: http://svn.apache.org/viewvc?rev=417146&view=rev
Log:
Apply patch for HARMONY-656.

Modified:
    incubator/harmony/enhanced/classlib/trunk/modules/nio/src/test/java/org/apache/harmony/tests/java/nio/channels/SocketChannelTest.java

Modified: incubator/harmony/enhanced/classlib/trunk/modules/nio/src/test/java/org/apache/harmony/tests/java/nio/channels/SocketChannelTest.java
URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/nio/src/test/java/org/apache/harmony/tests/java/nio/channels/SocketChannelTest.java?rev=417146&r1=417145&r2=417146&view=diff
==============================================================================
--- incubator/harmony/enhanced/classlib/trunk/modules/nio/src/test/java/org/apache/harmony/tests/java/nio/channels/SocketChannelTest.java
(original)
+++ incubator/harmony/enhanced/classlib/trunk/modules/nio/src/test/java/org/apache/harmony/tests/java/nio/channels/SocketChannelTest.java
Mon Jun 26 01:58:40 2006
@@ -396,10 +396,10 @@
 
         assertNull(s.getInetAddress());
         assertEquals(s.getLocalAddress().getHostAddress(), "0.0.0.0");
-        // FIXME -1 means not yet bound. this maybe a bug of RI
-        // RI can't pass this, it returns 0.
-        // assertEquals(s.getLocalPort(), -1);
-        // assertFalse(s.getReuseAddress());
+        // RI fails here. RI returns 0 while spec says unbound socket should
+        // return -1.
+        assertEquals(s.getLocalPort(), -1);
+        assertFalse(s.getReuseAddress());
         assertNull(s.getLocalSocketAddress());
 
         // not connected



Mime
View raw message