Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Message-ID: <27330389.1148274630155.JavaMail.jira@brutus>
Date: Mon, 22 May 2006 05:10:30 +0000 (GMT+00:00)
From: "Mikhail Loenko (JIRA)" <jira@apache.org>
To: harmony-commits@incubator.apache.org
Subject: [jira] Commented: (HARMONY-482) Some code compares Strings with ==
 operator
In-Reply-To: <6794237.1148040209769.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/HARMONY-482?page=comments#action_12412723 ] 

Mikhail Loenko commented on HARMONY-482:
----------------------------------------

If the code remains unmodified, this works fine.
I think the best way is to develop a unit test that would prevent undesired modifications in the code

> Some code compares Strings with == operator
> -------------------------------------------
>
>          Key: HARMONY-482
>          URL: http://issues.apache.org/jira/browse/HARMONY-482
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mikhail Fursov
>     Assignee: Mikhail Loenko
>     Priority: Trivial

>
> Some classes  (e.g. org.apache.harmony.luni.internal.net.www.protocol.http.HttpUrlConnection) use string comparison by reference instead of comparison by value.
> Such optimization is legal but can lead to problems with compatibility and bugs when part of the code refactored.
>         if (method == "GET")
>             setRequestMethod("POST");
>         // If the request method is neither PUT or POST, then you're not writing
>         if (method != "PUT" && method != "POST")
>             throw new ProtocolException(Msg.getString("K008f", method));

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira