Return-Path: 
 <harmony-commits-return-3690-apmail-incubator-harmony-commits-archive=incubator.apache.org@incubator.apache.org>
Delivered-To: apmail-incubator-harmony-commits-archive@www.apache.org
Received: (qmail 76989 invoked from network); 10 May 2006 06:13:49 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 10 May 2006 06:13:49 -0000
Received: (qmail 82121 invoked by uid 500); 10 May 2006 06:13:49 -0000
Delivered-To: apmail-incubator-harmony-commits-archive@incubator.apache.org
Received: (qmail 82084 invoked by uid 500); 10 May 2006 06:13:48 -0000
Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:harmony-commits-help@incubator.apache.org>
List-Unsubscribe: <mailto:harmony-commits-unsubscribe@incubator.apache.org>
List-Post: <mailto:harmony-commits@incubator.apache.org>
List-Id: <harmony-commits.incubator.apache.org>
Reply-To: harmony-dev@incubator.apache.org
Delivered-To: mailing list harmony-commits@incubator.apache.org
Received: (qmail 82072 invoked by uid 99); 10 May 2006 06:13:48 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 May 2006 23:13:48 -0700
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 May 2006 23:13:48 -0700
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 5261171429B
	for <harmony-commits@incubator.apache.org>;
 Wed, 10 May 2006 06:13:05 +0000 (GMT)
Message-ID: <24520556.1147241585334.JavaMail.jira@brutus>
Date: Wed, 10 May 2006 06:13:05 +0000 (GMT+00:00)
From: "Stepan Mishura (JIRA)" <jira@apache.org>
To: harmony-commits@incubator.apache.org
Subject: [jira] Resolved: (HARMONY-454) [classlib][luni] java.util.Set
 generics uplift and related changes
In-Reply-To: <1964609.1147231384413.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

     [ http://issues.apache.org/jira/browse/HARMONY-454?page=all ]
     
Stepan Mishura resolved HARMONY-454:
------------------------------------

    Resolution: Fixed

Hi Nathan,

Fixed in LUNI module at repo revision 405648. Please check that the fix resolved your issue.

Comments to the fix:
1) According to the spec. Set extends Collection that in turn extends Iterable. So Iterable is already superinterface for Set and IMHO we shouldn't extend it explicitly again i.e. the following is not required:
-public interface Set<E> extends Collection<E> {
+public interface Set<E> extends Collection<E>, Iterable<E> {
2) To avoid casting while-loop was replaced with for-loop. Could you review the change?

Thanks,
Stepan.

> [classlib][luni] java.util.Set generics uplift and related changes
> ------------------------------------------------------------------
>
>          Key: HARMONY-454
>          URL: http://issues.apache.org/jira/browse/HARMONY-454
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Nathan Beyer
>     Assignee: Stepan Mishura
>  Attachments: Set_etc_generics_patch.txt
>
> Complete java.util.Set generification and subsequent changes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira