Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Message-ID: <20513120.1147102821179.JavaMail.jira@brutus>
Date: Mon, 8 May 2006 15:40:21 +0000 (GMT+00:00)
From: "Tim Ellison (JIRA)" <jira@apache.org>
To: harmony-commits@incubator.apache.org
Subject: [jira] Resolved: (HARMONY-439) java build improvements - delegation
 to modules
In-Reply-To: <14996679.1146666234324.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

     [ http://issues.apache.org/jira/browse/HARMONY-439?page=all ]
     
Tim Ellison resolved HARMONY-439:
---------------------------------

    Resolution: Fixed

Thanks Mark,

Those tidy-ups look good.  I applied your patch at repo revision 405075.

Please check that the patch was applied as you expected.


> java build improvements - delegation to modules
> -----------------------------------------------
>
>          Key: HARMONY-439
>          URL: http://issues.apache.org/jira/browse/HARMONY-439
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Tim Ellison
>     Priority: Minor
>  Attachments: 01.delegate.build.to.modules.sh, 02.delegate.build.to.modules.diff
>
> There are a couple of issues that could be tidied up:
> 1) Currently we build java code into both 'build' and 'modules/*/bin/main' - we might avoid problems if we always built code to 'build'.  This also means we build everything twice ... once into 'build' then again into 'modules/*/bin/main' when the tests are run.
> 2) We build jars in two places 'make/build-java.xml' and 'modules/*/make/common/build.xml' - HARMONY-431 is proof that this is a bad idea.
> 3) To make matters worse 'make/build-java.xml' builds the jars to a location under 'build' where as the module build creates straight into 'deploy'.
> I suggest fixing these issues by delegating the building of the jars to the module ant files and to always build the code to the top-level 'build' directory.
> I will submit a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira