harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "George Harley (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HARMONY-435) DecimalFormatSymbolsTest.test_RIHarmony_compatible() passes or fails depending on location of resource
Date Mon, 08 May 2006 12:40:23 GMT
     [ http://issues.apache.org/jira/browse/HARMONY-435?page=all ]
     
George Harley resolved HARMONY-435:
-----------------------------------

    Resolution: Fixed

Hi Oliver, 

Thanks for catching this problem and for your suggested fix. We can go one step in simplifying
the fix by removing the need for URI altogether if we use the getResourceAsStream() method
of ClassLoader rather than getResource(). Modified version of your fix committed in revision
405036. Please could you check that this version of your fix works in your environment. 

Best regards, 
George

 

> DecimalFormatSymbolsTest.test_RIHarmony_compatible() passes or fails depending on location
of resource
> ------------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-435
>          URL: http://issues.apache.org/jira/browse/HARMONY-435
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Oliver Deakin
>     Assignee: George Harley
>     Priority: Trivial
>  Attachments: DecimalFormatSymbolsTest_create_valid_uri.diff
>
> The test method  test.java.org.apache.harmony.text.tests.java.text.DecimalFormatSymbolsTest.test_RIHarmony_compatible()
 attempts to load the resource DecimalFormatSymbols.ser. 
> However if this file is in a location whose full path contains a space character (e.g.
"c:\program files\<whatever>") the test case will fail. This is caused by the test using
the URI.create(String) method. URI.create() expects the string it takes as a parameter to
already be in valid URI form, which includes all space characters being quoted as %20. The
test currently passes in the path with no quoting of space characters, which causes an exception
to be thrown and the test to fail.
> I will attach a patch for the test that makes the trivial fix of using one of URI's constructors
that automatically converts the string to a valid URI, quoting any space it finds.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message