harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Hindess (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HARMONY-439) java build improvements - delegation to modules
Date Wed, 03 May 2006 14:29:46 GMT
     [ http://issues.apache.org/jira/browse/HARMONY-439?page=all ]

Mark Hindess updated HARMONY-439:
---------------------------------

    Attachment: 01.delegate.build.to.modules.sh
                02.delegate.build.to.modules.diff

The 01 script moves the patternsets to the modules and the 02 diff changes the ant files.
 In addition to fixing the specific issues mentioned, the patch also:

1) Moves the cleaning of the class files to build-java.xml (previously it was done in build.xml)

2) Sorts the source directory names in the top-level javac to make them easier to maintain.
(a fileset would be easier but the mix of src/main/common and src/main makes this difficult
to construct.)

3) Makes the auth source directories only common and the specific platform rather than both
platforms.

4) Adds a macro, '<call-modules target>',  to make it easier to call a target on all
modules.
 

> java build improvements - delegation to modules
> -----------------------------------------------
>
>          Key: HARMONY-439
>          URL: http://issues.apache.org/jira/browse/HARMONY-439
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Priority: Minor
>  Attachments: 01.delegate.build.to.modules.sh, 02.delegate.build.to.modules.diff
>
> There are a couple of issues that could be tidied up:
> 1) Currently we build java code into both 'build' and 'modules/*/bin/main' - we might
avoid problems if we always built code to 'build'.  This also means we build everything twice
... once into 'build' then again into 'modules/*/bin/main' when the tests are run.
> 2) We build jars in two places 'make/build-java.xml' and 'modules/*/make/common/build.xml'
- HARMONY-431 is proof that this is a bad idea.
> 3) To make matters worse 'make/build-java.xml' builds the jars to a location under 'build'
where as the module build creates straight into 'deploy'.
> I suggest fixing these issues by delegating the building of the jars to the module ant
files and to always build the code to the top-level 'build' directory.
> I will submit a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message