harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stepan Mishura (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HARMONY-454) [classlib][luni] java.util.Set generics uplift and related changes
Date Wed, 10 May 2006 06:13:05 GMT
     [ http://issues.apache.org/jira/browse/HARMONY-454?page=all ]
     
Stepan Mishura resolved HARMONY-454:
------------------------------------

    Resolution: Fixed

Hi Nathan,

Fixed in LUNI module at repo revision 405648. Please check that the fix resolved your issue.

Comments to the fix:
1) According to the spec. Set extends Collection that in turn extends Iterable. So Iterable
is already superinterface for Set and IMHO we shouldn't extend it explicitly again i.e. the
following is not required:
-public interface Set<E> extends Collection<E> {
+public interface Set<E> extends Collection<E>, Iterable<E> {
2) To avoid casting while-loop was replaced with for-loop. Could you review the change?

Thanks,
Stepan.

> [classlib][luni] java.util.Set generics uplift and related changes
> ------------------------------------------------------------------
>
>          Key: HARMONY-454
>          URL: http://issues.apache.org/jira/browse/HARMONY-454
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Nathan Beyer
>     Assignee: Stepan Mishura
>  Attachments: Set_etc_generics_patch.txt
>
> Complete java.util.Set generification and subsequent changes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message