harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Hindess (JIRA)" <j...@apache.org>
Subject [jira] Created: (HARMONY-458) Simplification of module build.xml files
Date Wed, 10 May 2006 18:00:04 GMT
Simplification of module build.xml files
----------------------------------------

         Key: HARMONY-458
         URL: http://issues.apache.org/jira/browse/HARMONY-458
     Project: Harmony
        Type: Improvement

  Components: Classlib  
    Reporter: Mark Hindess
    Priority: Minor


Looking at the logs, we've been making lots of changes to modules/*/make/common/build.xml
files but hardly any changes to modules/*/make/build.xml files.  This made me wonder what
this extra layer was adding and whether it was really being used as intended.

The "common" and "platform" distinction is confusing since the template in luni uses "platform"
to mean "natives".  And the auth module that has platform code just builds it using the javac
in the "common" build.xml.  I can't really see much to be gained by splitting "common" and
"platform" (in auth, for example); I think it would be just result in a lot of duplication.

I've had a go at removing this extra layer.  The result removes ~2000 lines of build files
and I think it makes it easier to see what is going on.  The resulting module build.xml files
are only ~150 lines long
and I don't think adding native build rules to these will make them unmanageably large so
I think we should stick to one build.xml file for that too.

I'll attach a patch and script with this simplification.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message