harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Hindess (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HARMONY-353) improvements to junit test method usage
Date Wed, 26 Apr 2006 14:42:03 GMT
     [ http://issues.apache.org/jira/browse/HARMONY-353?page=all ]

Mark Hindess updated HARMONY-353:
---------------------------------

    Attachment: final.attempt.to.catch.the.conflicts.diff

Stepan, Wow!  You were brave to take this on.  You got most of them and feel free to close
this issue.  We'll get them as we go along anyway.

However, I've attempted to capture those that were missed in the patch final.*.diff in case
you wish to apply it.


> improvements to junit test method usage
> ---------------------------------------
>
>          Key: HARMONY-353
>          URL: http://issues.apache.org/jira/browse/HARMONY-353
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Stepan Mishura
>     Priority: Trivial
>  Attachments: 01.assertnull.diff, 02.assertequals.string.diff, 03.assertequals.constants.diff,
04.assertequals.char.constants.diff, 05.assertnotnull.diff, assert.usage.combined.diff, combined.20060425.diff,
final.attempt.to.catch.the.conflicts.diff, improved.assertequals.usage.diff, text.only.update.20060426.diff
>
> While fixing the test in HARMONY-352, I found some confusing junit
> error messages.  They were things like:
>   error expected <actual> but got <expected>
> rather than:
>   error expected <expected> but got <actual>
> Because the arguments to the assertEquals method were the wrong way
> around.  The expected value should come first.  Anyway, I fixed these
> for that one test.  We should try to fix these when we find them and
> we should try to avoid adding any more.
> This JIRA is because I decided that it was reasonable to fix any method like:
>   assertEquals(..., <constant>);
> since a constant couldn't very well be the value being tested.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message