harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "George Harley (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HARMONY-158) Two JSE 5 methods are not implemented in java.util.zip.Deflator
Date Mon, 03 Apr 2006 16:01:56 GMT
     [ http://issues.apache.org/jira/browse/HARMONY-158?page=all ]
     
George Harley resolved HARMONY-158:
-----------------------------------

    Resolution: Fixed

Thanks Paulex, 

Applied patches to archive module and to native-src at repo revision 391073. 

I have some observations to make on this :

1) The native source patch code for this issue also made updates to the
inflater code which forced me to update inflater.c as well as deflater.c or
otherwise break the build. On closer inspection, it looks like this issue's
patch actually contains code that was intended for HARMONY-159 (see the updates
to the jclprots.h source). As HARMONY-158 and HARMONY-159 are so closely
related I am committing the fixes for both at the same time. It would have been
smoother had the patches actually been separate - assuming I have understood 
the problem correctly here. 


2) The patch to java/util/zip/Inflater.java does not update the signature of
the native method getTotalOutImpl to reflect the change of return type from int
to long. That looks like an ommission. So, instead of ...

private native synchronized int getTotalOutImpl(long handle);

...it looks like it *should* be ...

private native synchronized long getTotalOutImpl(long handle);

It's minor but I have remedied this in the committed version of
java/util/zip/Inflater.java .


3) I have a gut feeling that there could be more test code for these changes.
What do you think ?


4) The Javadoc comments for the new methods (e.g. getBytesRead) don't contain much explanation.
What do you think ?

Please check that the patch was applied as you expected. 

Best regards, 
George


> Two JSE 5 methods are not implemented in java.util.zip.Deflator
> ---------------------------------------------------------------
>
>          Key: HARMONY-158
>          URL: http://issues.apache.org/jira/browse/HARMONY-158
>      Project: Harmony
>         Type: Bug

>     Reporter: Paulex Yang
>  Attachments: 158-native-patch.txt, java.util.zip.Deflater.patch, java.util.zip.DeflaterTests.patch
>
> Two methods:
> java/util/zip/Deflater public getBytesRead()J
> java/util/zip/Deflater public getBytesWritten()J 
> are introduced by JSE 5, but they are not been implemented by Harmony yet. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message