harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Loenko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-353) improvements to junit test method usage
Date Mon, 17 Apr 2006 12:37:19 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-353?page=comments#action_12374740 ] 

Mikhail Loenko commented on HARMONY-353:
----------------------------------------

Mark,

SVN reports a lot of errors when I'm applying patches in the described order.
Could you please submit a single patch with all the changes?

Thanks,
Mikhail

> improvements to junit test method usage
> ---------------------------------------
>
>          Key: HARMONY-353
>          URL: http://issues.apache.org/jira/browse/HARMONY-353
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Mikhail Loenko
>     Priority: Trivial
>  Attachments: 01.assertnull.diff, 02.assertequals.string.diff, 03.assertequals.constants.diff,
04.assertequals.char.constants.diff, 05.assertnotnull.diff, improved.assertequals.usage.diff
>
> While fixing the test in HARMONY-352, I found some confusing junit
> error messages.  They were things like:
>   error expected <actual> but got <expected>
> rather than:
>   error expected <expected> but got <actual>
> Because the arguments to the assertEquals method were the wrong way
> around.  The expected value should come first.  Anyway, I fixed these
> for that one test.  We should try to fix these when we find them and
> we should try to avoid adding any more.
> This JIRA is because I decided that it was reasonable to fix any method like:
>   assertEquals(..., <constant>);
> since a constant couldn't very well be the value being tested.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message