harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stepan Mishura (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-353) improvements to junit test method usage
Date Wed, 26 Apr 2006 08:55:03 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-353?page=comments#action_12376432 ] 

Stepan Mishura commented on HARMONY-353:
----------------------------------------

Thanks Mark for such big tests improvement!

I've splitted update. I've applied your combined patch to following modules:
1) ARCHIVE - revision 396855
2) AUTH - revision 396860
3) CRYPTO -revision 396862
4) LUNI - revision 397123 (I excluded conflicts and one failed test)
5) MATH - revision 397135 (I excluded conflicts)
6) NIO_CHAR - revision 396872
7) REGEX - revision 397139
8) SECURITY - revision 397071
9) SQL - revision 396869

Waiting for patch for TEXT module.

> improvements to junit test method usage
> ---------------------------------------
>
>          Key: HARMONY-353
>          URL: http://issues.apache.org/jira/browse/HARMONY-353
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Stepan Mishura
>     Priority: Trivial
>  Attachments: 01.assertnull.diff, 02.assertequals.string.diff, 03.assertequals.constants.diff,
04.assertequals.char.constants.diff, 05.assertnotnull.diff, assert.usage.combined.diff, combined.20060425.diff,
improved.assertequals.usage.diff
>
> While fixing the test in HARMONY-352, I found some confusing junit
> error messages.  They were things like:
>   error expected <actual> but got <expected>
> rather than:
>   error expected <expected> but got <actual>
> Because the arguments to the assertEquals method were the wrong way
> around.  The expected value should come first.  Anyway, I fixed these
> for that one test.  We should try to fix these when we find them and
> we should try to avoid adding any more.
> This JIRA is because I decided that it was reasonable to fix any method like:
>   assertEquals(..., <constant>);
> since a constant couldn't very well be the value being tested.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message