harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Hindess (JIRA)" <j...@apache.org>
Subject [jira] Created: (HARMONY-353) improvements to junit test method usage
Date Sat, 15 Apr 2006 20:19:00 GMT
improvements to junit test method usage
---------------------------------------

         Key: HARMONY-353
         URL: http://issues.apache.org/jira/browse/HARMONY-353
     Project: Harmony
        Type: Improvement

  Components: Classlib  
    Reporter: Mark Hindess
    Priority: Trivial


While fixing the test in HARMONY-352, I found some confusing junit
error messages.  They were things like:

  error expected <actual> but got <expected>

rather than:

  error expected <expected> but got <actual>

Because the arguments to the assertEquals method were the wrong way
around.  The expected value should come first.  Anyway, I fixed these
for that one test.  We should try to fix these when we find them and
we should try to avoid adding any more.

This JIRA is because I decided that it was reasonable to fix any method like:

  assertEquals(..., <constant>);

since a constant couldn't very well be the value being tested.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message