Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Message-ID: <2127867587.1143230017890.JavaMail.jira@ajax>
Date: Fri, 24 Mar 2006 19:53:37 +0000 (GMT)
From: "Vasily Zakharov (JIRA)" <jira@apache.org>
To: harmony-commits@incubator.apache.org
Subject: [jira] Commented: (HARMONY-220) javax.naming.NameClassPair lacks
 two Java 5.0 methods
In-Reply-To: <1227703281.1142938803654.JavaMail.jira@ajax>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/HARMONY-220?page=comments#action_12371789 ] 

Vasily Zakharov commented on HARMONY-220:
-----------------------------------------

Tim,

Thank you for applying the patch. It does what it should.

One small note - the file uses spaces for indents, and you used tabs for some reason, which makes the file bad-looking if tab size is set to the width other than 4.
Just in case you find it significant, I here attach a small patch to fix it (NameClassPairSpaces.patch).

Mark,

I see, the tests have the same problem - they check name for null, while the spec clearly states that name must be non-null.
Here I attach a patch for the tests, it should resolve the failures (NameClassPairTest.patch).
Thank you.


> javax.naming.NameClassPair lacks two Java 5.0 methods
> -----------------------------------------------------
>
>          Key: HARMONY-220
>          URL: http://issues.apache.org/jira/browse/HARMONY-220
>      Project: Harmony
>         Type: Bug
>   Components: Classlib
>     Reporter: Vasily Zakharov
>     Assignee: Tim Ellison
>  Attachments: NameClassPair.patch
>
> javax.naming.NameClassPair lacks implementation for two Java 5.0 methods:
> String getNameInNamespace()
> void setNameInNamespace(String)
> Also specification for both constructors and the setName(String) method states that name parameter must be non-null. The current implementation lacks checking of this fact.
> The attached simple patch provides fixes for both issues.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira