harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Hindess (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-183) refactor linux specific parts of nethelp.c then make it shared code
Date Tue, 28 Mar 2006 13:26:31 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-183?page=comments#action_12372108 ] 

Mark Hindess commented on HARMONY-183:
--------------------------------------

Looks as I expected.  (Apart from the >80 character line in the Linux makefile, but I'll
fix that next time I submit a diff that modifies it. ;-)


> refactor linux specific parts of nethelp.c then make it shared code
> -------------------------------------------------------------------
>
>          Key: HARMONY-183
>          URL: http://issues.apache.org/jira/browse/HARMONY-183
>      Project: Harmony
>         Type: Improvement
>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Tim Ellison
>     Priority: Minor
>  Attachments: 02.nethelp.refactor.diff
>
> nethelp.c in win and linux natives are identical apart from a linux specific function.
 I'd suggest moving the linux specific function to a new file, OSNetworkSystemLinux.c, then
making nethelp.c a shared source file.  I'll attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message