hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward J. Yoon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HAMA-996) Delete meaningless parameter
Date Fri, 26 Aug 2016 00:03:20 GMT

    [ https://issues.apache.org/jira/browse/HAMA-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438170#comment-15438170
] 

Edward J. Yoon commented on HAMA-996:
-------------------------------------

I think TaskInProgress.getRecoveryTask() is related with task recovery. If ft service is enabled,
the framework checkpoints statuses perioidically. When tasks failed or crashed, the framework
recover the tasks from previous checkpoint automatically. It seems GroomServer.startRecoveryTask()
and AsyncRcvdMsgCheckpointImpl.restartTask()'s role is for that.

If TaskInProgress.getRecoveryTask() is useless code, we can remove them or add tags @Deprecated
with some comments.



> Delete meaningless parameter
> ----------------------------
>
>                 Key: HAMA-996
>                 URL: https://issues.apache.org/jira/browse/HAMA-996
>             Project: Hama
>          Issue Type: Improvement
>            Reporter: JongYoon Lim
>            Priority: Trivial
>         Attachments: HAMA-996.patch
>
>
> It seems that *taskid* param from *getGroomToSchedule()* of *TaskInProgress* is not essential
for this function. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message