hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Minho Kim (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HAMA-980) Modify configuration value from "hama.sync.client.class" to "hama.sync.peer.class"
Date Thu, 19 Nov 2015 07:01:11 GMT
Minho Kim created HAMA-980:
------------------------------

             Summary: Modify configuration value from "hama.sync.client.class" to "hama.sync.peer.class"
                 Key: HAMA-980
                 URL: https://issues.apache.org/jira/browse/HAMA-980
             Project: Hama
          Issue Type: Bug
          Components: test 
    Affects Versions: 0.7.0
            Reporter: Minho Kim
            Priority: Minor
             Fix For: 0.7.0


Configuration value, "hama.sync.client.class", is never used. Because configuration value
to run test code is not "hama.sync.client.classe" but "hama.sync.peer.class".

In BSPPeerImpl.java, configuration value refer to SYNC_PEER_CLASS so as to initialize syncClient.
But SYNC_PEER_CLASS is "hama.sync.peer.class" so it's no use setting "hama.sync.client.class".

{code:title=SyncServiceFactory.java}
public static final String SYNC_SERVER_CLASS = "hama.sync.server.class";
  public static final String SYNC_PEER_CLASS = "hama.sync.peer.class";
  public static final String SYNC_MASTER_CLASS = "hama.sync.master.class";

  /**
   * Returns a sync client via reflection based on what was configured.
   */
  public static PeerSyncClient getPeerSyncClient(Configuration conf)
      throws ClassNotFoundException {
    return (PeerSyncClient) ReflectionUtils.newInstance(conf
        .getClassByName(conf.get(SYNC_PEER_CLASS,
            ZooKeeperSyncClientImpl.class.getName())), conf);
  }
{code}

We need to modify configuration value from "hama.sync.client.class" to "hama.sync.peer.class"
in test codes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message