hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HAMA-967) Remove a meaningless checking condition.
Date Tue, 28 Jul 2015 00:07:04 GMT

    [ https://issues.apache.org/jira/browse/HAMA-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643638#comment-14643638
] 

Hudson commented on HAMA-967:
-----------------------------

SUCCESS: Integrated in Hama-Nightly-for-Hadoop-1.x #1684 (See [https://builds.apache.org/job/Hama-Nightly-for-Hadoop-1.x/1684/])
HAMA-967: Remove a meaningless checking condition (JongYoon Lim via edwardyoon) (edwardyoon:
rev 1692800)
* /hama/trunk/CHANGES.txt
* /hama/trunk/core/src/main/java/org/apache/hama/ipc/AsyncRPC.java
* /hama/trunk/core/src/main/java/org/apache/hama/ipc/RPC.java


> Remove a meaningless checking condition.
> ----------------------------------------
>
>                 Key: HAMA-967
>                 URL: https://issues.apache.org/jira/browse/HAMA-967
>             Project: Hama
>          Issue Type: Bug
>          Components: bsp core
>    Affects Versions: 0.7.0
>            Reporter: JongYoon Lim
>            Assignee: JongYoon Lim
>            Priority: Trivial
>              Labels: cleanup
>             Fix For: 0.7.1
>
>         Attachments: HAMA-967.patch
>
>
> *split()* of *String* in *RPC* and *AsyncRPC* returns the array of strings. So checking
*null* condition is meaningless. 
> {code:java}
> String[] names = className.split("\\.", -1);
> if (names == null || names.length == 0) {
>   return className;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message