hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward J. Yoon (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HAMA-726) Hama on Mesos
Date Tue, 01 Jul 2014 05:58:25 GMT

    [ https://issues.apache.org/jira/browse/HAMA-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048544#comment-14048544
] 

Edward J. Yoon edited comment on HAMA-726 at 7/1/14 5:56 AM:
-------------------------------------------------------------

Hi [~jfenc91], I wonder why did you use double quotation twice?

{code}
@@ -202,14 +210,15 @@ if $cygwin; then
   JAVA_LIBRARY_PATH=`cygpath -p "$JAVA_LIBRARY_PATH"`
 fi
 
-HAMA_OPTS="$HAMA_OPTS -Dhama.log.dir=$HAMA_LOG_DIR"
-HAMA_OPTS="$HAMA_OPTS -Dhama.log.file=$HAMA_LOGFILE"
-HAMA_OPTS="$HAMA_OPTS -Dhama.home.dir=$HAMA_HOME"
-HAMA_OPTS="$HAMA_OPTS -Dhama.id.str=$HAMA_IDENT_STRING"
-HAMA_OPTS="$HAMA_OPTS -Dhama.root.logger=${HAMA_ROOT_LOGGER:-INFO,console}"
+HAMA_OPTS=""$HAMA_OPTS"-Dhama.log.dir=\"${HAMA_LOG_DIR}\""
+HAMA_OPTS=""$HAMA_OPTS" -Dhama.log.file=$HAMA_LOGFILE"
+HAMA_OPTS=""$HAMA_OPTS" -Dhama.home.dir=\"$HAMA_HOME\""
+HAMA_OPTS=""$HAMA_OPTS" -Dhama.id.str=$HAMA_IDENT_STRING"
+HAMA_OPTS=""$HAMA_OPTS" -Dhama.root.logger=${HAMA_ROOT_LOGGER:-INFO,console}"
 if [ "x$JAVA_LIBRARY_PATH" != "x" ]; then
-  HAMA_OPTS="$HAMA_OPTS -Djava.library.path=$JAVA_LIBRARY_PATH"
-fi  
-HAMA_OPTS="$HAMA_OPTS -Dhama.policy.file=$HAMA_POLICYFILE"
+  HAMA_OPTS=""$HAMA_OPTS" -Djava.library.path=$JAVA_LIBRARY_PATH"
+fi
+HAMA_OPTS=""$HAMA_OPTS" -Dhama.policy.file=$HAMA_POLICYFILE"
+
 # run it
-exec "$JAVA" $JAVA_HEAP_MAX $HAMA_OPTS -classpath "$CLASSPATH" $CLASS "$@"
+exec "$JAVA" "$JAVA_HEAP_MAX" "$HAMA_OPTS" -classpath "$CLASSPATH" $CLASS "$@"
{code}

When I run Hama as a classic-mode, system creates odd directories and can't find the proper
path.

{code}
edward@edward-VirtualBox:~/workspace/hama-trunk$ ls
"    c++          commons  contrib  dist  examples  lib          logs   ml          pom.xml
    src     yarn
bin  CHANGES.txt  conf     core     docs  graph     LICENSE.txt  mesos  NOTICE.txt  README.txt
 target
edward@edward-VirtualBox:~/workspace/hama-trunk$ ls '"'
home
edward@edward-VirtualBox:~/workspace/hama-trunk$ ls '"/home/'
edward
{code}



was (Author: udanax):
Hi [~jfenc91], I wonder why did you use double quotation again?

{code}
@@ -202,14 +210,15 @@ if $cygwin; then
   JAVA_LIBRARY_PATH=`cygpath -p "$JAVA_LIBRARY_PATH"`
 fi
 
-HAMA_OPTS="$HAMA_OPTS -Dhama.log.dir=$HAMA_LOG_DIR"
-HAMA_OPTS="$HAMA_OPTS -Dhama.log.file=$HAMA_LOGFILE"
-HAMA_OPTS="$HAMA_OPTS -Dhama.home.dir=$HAMA_HOME"
-HAMA_OPTS="$HAMA_OPTS -Dhama.id.str=$HAMA_IDENT_STRING"
-HAMA_OPTS="$HAMA_OPTS -Dhama.root.logger=${HAMA_ROOT_LOGGER:-INFO,console}"
+HAMA_OPTS=""$HAMA_OPTS"-Dhama.log.dir=\"${HAMA_LOG_DIR}\""
+HAMA_OPTS=""$HAMA_OPTS" -Dhama.log.file=$HAMA_LOGFILE"
+HAMA_OPTS=""$HAMA_OPTS" -Dhama.home.dir=\"$HAMA_HOME\""
+HAMA_OPTS=""$HAMA_OPTS" -Dhama.id.str=$HAMA_IDENT_STRING"
+HAMA_OPTS=""$HAMA_OPTS" -Dhama.root.logger=${HAMA_ROOT_LOGGER:-INFO,console}"
 if [ "x$JAVA_LIBRARY_PATH" != "x" ]; then
-  HAMA_OPTS="$HAMA_OPTS -Djava.library.path=$JAVA_LIBRARY_PATH"
-fi  
-HAMA_OPTS="$HAMA_OPTS -Dhama.policy.file=$HAMA_POLICYFILE"
+  HAMA_OPTS=""$HAMA_OPTS" -Djava.library.path=$JAVA_LIBRARY_PATH"
+fi
+HAMA_OPTS=""$HAMA_OPTS" -Dhama.policy.file=$HAMA_POLICYFILE"
+
 # run it
-exec "$JAVA" $JAVA_HEAP_MAX $HAMA_OPTS -classpath "$CLASSPATH" $CLASS "$@"
+exec "$JAVA" "$JAVA_HEAP_MAX" "$HAMA_OPTS" -classpath "$CLASSPATH" $CLASS "$@"
{code}

When I run Hama as a classic-mode, system creates odd directories and can't find the proper
path.

{code}
edward@edward-VirtualBox:~/workspace/hama-trunk$ ls
"    c++          commons  contrib  dist  examples  lib          logs   ml          pom.xml
    src     yarn
bin  CHANGES.txt  conf     core     docs  graph     LICENSE.txt  mesos  NOTICE.txt  README.txt
 target
edward@edward-VirtualBox:~/workspace/hama-trunk$ ls '"'
home
edward@edward-VirtualBox:~/workspace/hama-trunk$ ls '"/home/'
edward
{code}


> Hama on Mesos
> -------------
>
>                 Key: HAMA-726
>                 URL: https://issues.apache.org/jira/browse/HAMA-726
>             Project: Hama
>          Issue Type: New Feature
>          Components: bsp core
>            Reporter: Suraj Menon
>            Assignee: Jeff Fenchel
>             Fix For: 0.7.0
>
>         Attachments: HAMA-726-v2.patch, HAMA-726.patch
>
>
> Since we are going to refactor our code to work on YARN, it would be nice to keep our
abstraction levels to make it feasible to work on Mesos. 
> Documentation: http://incubator.apache.org/mesos/documentation.html
> Framework development guide:
> https://github.com/mesos/mesos/wiki/App-Framework-development-guide



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message