hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anastasis Andronidis (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HAMA-568) Add faster synchronized collections for message queues
Date Tue, 11 Mar 2014 15:59:43 GMT

    [ https://issues.apache.org/jira/browse/HAMA-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13930492#comment-13930492
] 

Anastasis Andronidis commented on HAMA-568:
-------------------------------------------

+1, only one small note, in your patch you have an unused semicolon:

{code}
   @Override
   public void close() {
-    this.clear();;
+    this.clear();
+    ;
   }
{code}

> Add faster synchronized collections for message queues
> ------------------------------------------------------
>
>                 Key: HAMA-568
>                 URL: https://issues.apache.org/jira/browse/HAMA-568
>             Project: Hama
>          Issue Type: Sub-task
>            Reporter: Thomas Jungblut
>            Assignee: Edward J. Yoon
>             Fix For: 0.7.0
>
>         Attachments: HAMA-568.patch, HAMA-568_1.patch, HAMA-568_2.patch
>
>
> Currently the synchronized messaging (accessed concurrently via RPC) is done with a single
mutex object. See org.apache.hama.bsp.message.SynchronizedQueue.
> This can be improved for memory queue by adding the ConcurrentLinkedQueue from Java since
it has higher throughput. 
> Needless to say, we should add some custom synchronized version of a queue, maybe through
a factory class in the normal version.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message