Return-Path: X-Original-To: apmail-hama-dev-archive@www.apache.org Delivered-To: apmail-hama-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4DE2E10644 for ; Wed, 22 Jan 2014 05:38:29 +0000 (UTC) Received: (qmail 78226 invoked by uid 500); 22 Jan 2014 05:38:29 -0000 Delivered-To: apmail-hama-dev-archive@hama.apache.org Received: (qmail 77565 invoked by uid 500); 22 Jan 2014 05:38:22 -0000 Mailing-List: contact dev-help@hama.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hama.apache.org Delivered-To: mailing list dev@hama.apache.org Received: (qmail 77536 invoked by uid 99); 22 Jan 2014 05:38:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jan 2014 05:38:20 +0000 Date: Wed, 22 Jan 2014 05:38:19 +0000 (UTC) From: "Edward J. Yoon (JIRA)" To: dev@hama.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HAMA-857) Graph Combiners is wrongly implemented MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HAMA-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward J. Yoon updated HAMA-857: -------------------------------- Attachment: combine.patch This patch combines the messages before sending to another peers. The number of combined messages = TOTAL_MESSAGES_SENT - TOTAL_MESSAGES_RECEIVED {code} 14/01/22 14:26:16 INFO bsp.BSPJobClient: TOTAL_MESSAGES_SENT=81 14/01/22 14:26:16 INFO bsp.BSPJobClient: TOTAL_MESSAGES_RECEIVED=79 {code} > Graph Combiners is wrongly implemented > -------------------------------------- > > Key: HAMA-857 > URL: https://issues.apache.org/jira/browse/HAMA-857 > Project: Hama > Issue Type: Bug > Components: graph > Affects Versions: 0.6.3 > Reporter: Edward J. Yoon > Priority: Critical > Fix For: 0.7.0 > > Attachments: combine.patch > > > Current implementation combines the already received messages. > {code} > if (combiner != null) { > M combined = combiner.combine(iterable); > vertex.compute(Collections.singleton(combined)); > } else { > vertex.compute(iterable); > } > {code} > Messages should be combined before sending to another vertex. -- This message was sent by Atlassian JIRA (v6.1.5#6160)