Return-Path: X-Original-To: apmail-hama-dev-archive@www.apache.org Delivered-To: apmail-hama-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 262DC10B9D for ; Tue, 29 Oct 2013 09:30:37 +0000 (UTC) Received: (qmail 59899 invoked by uid 500); 29 Oct 2013 09:30:36 -0000 Delivered-To: apmail-hama-dev-archive@hama.apache.org Received: (qmail 59566 invoked by uid 500); 29 Oct 2013 09:30:33 -0000 Mailing-List: contact dev-help@hama.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hama.apache.org Delivered-To: mailing list dev@hama.apache.org Received: (qmail 59158 invoked by uid 99); 29 Oct 2013 09:30:32 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Oct 2013 09:30:32 +0000 Date: Tue, 29 Oct 2013 09:30:32 +0000 (UTC) From: "Martin Illecker (JIRA)" To: dev@hama.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HAMA-699) Add commons module MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HAMA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13807830#comment-13807830 ] Martin Illecker commented on HAMA-699: -------------------------------------- Yes, I would need VectorWritable and DenseDoubleVector in core for a test case. (cyclic dependency of core and ml) But regarding to ChiaHung Lin, maybe we should reduce the patch a little bit? And move writables from o.a.h.c.io.w to o.a.h.c.io. I will create a new reduced patch including the following structure: {code} org.apache.hama.commons.io.DenseVectorWritable.java org.apache.hama.commons.io.MatrixWritable.java org.apache.hama.commons.io.SparseVectorWritable.java org.apache.hama.commons.io.StringArrayWritable.java org.apache.hama.commons.io.TextArrayWritable.java org.apache.hama.commons.io.VectorWritable.java org.apache.hama.commons.math.CrossEntropy.java org.apache.hama.commons.math.DenseDoubleMatrix.java org.apache.hama.commons.math.DenseDoubleVector.java org.apache.hama.commons.math.DoubleDoubleFunction.java org.apache.hama.commons.math.DoubleDoubleVectorFunction.java org.apache.hama.commons.math.DoubleFunction.java org.apache.hama.commons.math.DoubleMatrix.java org.apache.hama.commons.math.DoubleVector.java org.apache.hama.commons.math.DoubleVectorFunction.java org.apache.hama.commons.math.Function.java org.apache.hama.commons.math.FunctionFactory.java org.apache.hama.commons.math.IdentityFunction.java org.apache.hama.commons.math.Sigmoid.java org.apache.hama.commons.math.SquaredError.java org.apache.hama.commons.math.Tanh.java org.apache.hama.commons.math.Tuple.java org.apache.hama.commons.util.KeyValuePair.java org.apache.hama.commons.util.TextPair.java Test classes: org.apache.hama.commons.math.TestDenseDoubleMatrix.java org.apache.hama.commons.math.TestDenseDoubleVector.java org.apache.hama.commons.math.TestFunctionFactory.java {code} Only org.apache.hama.ml.math, KeyValuePair, TextPair and writables will be moved to commons. > Add commons module > ------------------ > > Key: HAMA-699 > URL: https://issues.apache.org/jira/browse/HAMA-699 > Project: Hama > Issue Type: Improvement > Reporter: Edward J. Yoon > Fix For: 0.7.0 > > Attachments: commons-module.txt, HAMA-699.patch > > > As we disscussed, I'd like to add commons module. -- This message was sent by Atlassian JIRA (v6.1#6144)