hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Illecker (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HAMA-699) Add commons module
Date Tue, 29 Oct 2013 09:30:32 GMT

    [ https://issues.apache.org/jira/browse/HAMA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13807830#comment-13807830
] 

Martin Illecker commented on HAMA-699:
--------------------------------------

Yes, I would need VectorWritable and DenseDoubleVector in core for a test case. (cyclic dependency
of core and ml)
But regarding to ChiaHung Lin, maybe we should reduce the patch a little bit? And move writables
from o.a.h.c.io.w to o.a.h.c.io. 

I will create a new reduced patch including the following structure:
{code}
org.apache.hama.commons.io.DenseVectorWritable.java
org.apache.hama.commons.io.MatrixWritable.java
org.apache.hama.commons.io.SparseVectorWritable.java
org.apache.hama.commons.io.StringArrayWritable.java
org.apache.hama.commons.io.TextArrayWritable.java
org.apache.hama.commons.io.VectorWritable.java

org.apache.hama.commons.math.CrossEntropy.java
org.apache.hama.commons.math.DenseDoubleMatrix.java
org.apache.hama.commons.math.DenseDoubleVector.java
org.apache.hama.commons.math.DoubleDoubleFunction.java
org.apache.hama.commons.math.DoubleDoubleVectorFunction.java
org.apache.hama.commons.math.DoubleFunction.java
org.apache.hama.commons.math.DoubleMatrix.java
org.apache.hama.commons.math.DoubleVector.java
org.apache.hama.commons.math.DoubleVectorFunction.java
org.apache.hama.commons.math.Function.java
org.apache.hama.commons.math.FunctionFactory.java
org.apache.hama.commons.math.IdentityFunction.java
org.apache.hama.commons.math.Sigmoid.java
org.apache.hama.commons.math.SquaredError.java
org.apache.hama.commons.math.Tanh.java
org.apache.hama.commons.math.Tuple.java

org.apache.hama.commons.util.KeyValuePair.java
org.apache.hama.commons.util.TextPair.java

Test classes:
org.apache.hama.commons.math.TestDenseDoubleMatrix.java
org.apache.hama.commons.math.TestDenseDoubleVector.java
org.apache.hama.commons.math.TestFunctionFactory.java
{code}

Only org.apache.hama.ml.math, KeyValuePair, TextPair and writables will be moved to commons.

> Add commons module
> ------------------
>
>                 Key: HAMA-699
>                 URL: https://issues.apache.org/jira/browse/HAMA-699
>             Project: Hama
>          Issue Type: Improvement
>            Reporter: Edward J. Yoon
>             Fix For: 0.7.0
>
>         Attachments: commons-module.txt, HAMA-699.patch
>
>
> As we disscussed, I'd like to add commons module.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message