hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Illecker (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HAMA-699) Add commons module
Date Mon, 28 Oct 2013 09:47:31 GMT

    [ https://issues.apache.org/jira/browse/HAMA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806659#comment-13806659
] 

Martin Illecker commented on HAMA-699:
--------------------------------------

Thanks for your explanation.
I understand your concerns and then we should move writables from o.a.h.c.io.w to o.a.h.c.io.

(by the way writables don't have any dependency to other io classes / interfaces)
To keep the modifications as small as possible (reducing risks of instability and easier debugging
in case of problems) I would suggest the following commons module:
{code}
org.apache.hama.commons.io.DenseVectorWritable.java
org.apache.hama.commons.io.MatrixWritable.java
org.apache.hama.commons.io.SparseVectorWritable.java
org.apache.hama.commons.io.StringArrayWritable.java
org.apache.hama.commons.io.TextArrayWritable.java
org.apache.hama.commons.io.VectorWritable.java

org.apache.hama.commons.math.CrossEntropy.java
org.apache.hama.commons.math.DenseDoubleMatrix.java
org.apache.hama.commons.math.DenseDoubleVector.java
org.apache.hama.commons.math.DoubleDoubleFunction.java
org.apache.hama.commons.math.DoubleDoubleVectorFunction.java
org.apache.hama.commons.math.DoubleFunction.java
org.apache.hama.commons.math.DoubleMatrix.java
org.apache.hama.commons.math.DoubleVector.java
org.apache.hama.commons.math.DoubleVectorFunction.java
org.apache.hama.commons.math.Function.java
org.apache.hama.commons.math.FunctionFactory.java
org.apache.hama.commons.math.IdentityFunction.java
org.apache.hama.commons.math.Sigmoid.java
org.apache.hama.commons.math.SquaredError.java
org.apache.hama.commons.math.Tanh.java
org.apache.hama.commons.math.Tuple.java

org.apache.hama.commons.util.KeyValuePair.java
org.apache.hama.commons.util.TextPair.java

Test classes:
org.apache.hama.commons.math.TestDenseDoubleMatrix.java
org.apache.hama.commons.math.TestDenseDoubleVector.java
org.apache.hama.commons.math.TestFunctionFactory.java
{code}

If this patch is too big, please provide your proposal. 
(I would need VectorWritable and DenseDoubleVector in a common module, to use it in core)
Thanks!

> Add commons module
> ------------------
>
>                 Key: HAMA-699
>                 URL: https://issues.apache.org/jira/browse/HAMA-699
>             Project: Hama
>          Issue Type: Improvement
>            Reporter: Edward J. Yoon
>            Assignee: Martin Illecker
>             Fix For: 0.7.0
>
>         Attachments: commons-module.txt, HAMA-699.patch
>
>
> As we disscussed, I'd like to add commons module.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message